fails to import a module because of invalid utf8 sequence from npm packages about deno

[sigmaSd]

deno 1.43.6+a892353 (canary, x86_64-unknown-linux-gnu)

[sigmaSd]

The last debug message is coming from here

deno/cli/npm/managed/mod.rs

Line 302 in a892353

"Resolved package folder of {} to {}",

so the error is not in deno graph anymore, maybe its in deno npm

[dsherret]

so the error is not in deno graph anymore, maybe its in deno npm

No, at this point it would be node execution. It's probably in https://github.com/denoland/deno/tree/main/ext/node

[sigmaSd]

Seems like there are a couple of places that have this wrong assumption:

https://github.com/denoland/deno/blob/main/ext/fs/interface.rs#L303 which is called from https://github.com/denoland/deno/blob/main/cli/resolver.rs#L296

changing that to utf8_lossy, gets through that point, but now there is another error which seems coming from node module

error: Uncaught (in promise) InvalidData: invalid utf-8 sequence of 1 bytes from index 165105
    at Object.Module._extensions..js (node:module:1053:19)
    at Module.load (node:module:912:32)
    at Function.Module._load (node:module:721:12)
    at Module.require (node:module:934:19)
    at require (node:module:1119:16)
    at file:///home/gitpod/.cache/deno/npm/registry.npmjs.org/js-clipper/1.0.1/clipper.js:3:13

[sigmaSd]

Everything works if I change https://github.com/denoland/deno/blob/main/ext/fs/interface.rs#L293 and https://github.com/denoland/deno/blob/main/ext/fs/interface.rs#L303 to utf8_lossy

One is called from https://github.com/denoland/deno/blob/main/cli/resolver.rs#L296 and the other from https://github.com/denoland/deno/blob/main/ext/node/polyfills/01_require.js#L1053

@dsherret is it an ok fix to make them utf8lossy ? would be great if someone picks this up, I don't have time to figure out tests