Comments (5)
deno 1.43.6+a892353 (canary, x86_64-unknown-linux-gnu)
from deno.
The last debug message is coming from here
Line 302 in a892353
so the error is not in deno graph anymore, maybe its in deno npm
from deno.
so the error is not in deno graph anymore, maybe its in deno npm
No, at this point it would be node execution. It's probably in https://github.com/denoland/deno/tree/main/ext/node
from deno.
Seems like there are a couple of places that have this wrong assumption:
https://github.com/denoland/deno/blob/main/ext/fs/interface.rs#L303 which is called from https://github.com/denoland/deno/blob/main/cli/resolver.rs#L296
changing that to utf8_lossy, gets through that point, but now there is another error which seems coming from node module
error: Uncaught (in promise) InvalidData: invalid utf-8 sequence of 1 bytes from index 165105
at Object.Module._extensions..js (node:module:1053:19)
at Module.load (node:module:912:32)
at Function.Module._load (node:module:721:12)
at Module.require (node:module:934:19)
at require (node:module:1119:16)
at file:///home/gitpod/.cache/deno/npm/registry.npmjs.org/js-clipper/1.0.1/clipper.js:3:13
from deno.
Everything works if I change https://github.com/denoland/deno/blob/main/ext/fs/interface.rs#L293 and https://github.com/denoland/deno/blob/main/ext/fs/interface.rs#L303 to utf8_lossy
One is called from https://github.com/denoland/deno/blob/main/cli/resolver.rs#L296 and the other from https://github.com/denoland/deno/blob/main/ext/node/polyfills/01_require.js#L1053
@dsherret is it an ok fix to make them utf8lossy ? would be great if someone picks this up, I don't have time to figure out tests
from deno.
Related Issues (20)
- node:diagnostic_channel misses `DiagnosticChannel::tracingChannel` API
- Cannot read properties of undefined (reading 'env') HOT 1
- Allow classes with `fetch` method for `deno serve`.
- thread 'worker-2' panicked at cli/npm/managed/resolution.rs:231:72: called `Option::unwrap()` on a `None` value HOT 6
- Uncaught SyntaxError: Unexpected reserved word HOT 2
- dynamic import of async module from worker HOT 4
- Make test output slightly easier to read HOT 3
- bug: `JSR package manifest for '@std/uuid' failed to load. Access is denied. (os error 5)` in `std` HOT 2
- `websocket.send()` does not respect the order of messages HOT 3
- `deno publish` to jsr does not resolve `@deno-types="..."`
- `Napi::Buffer<uint8_t>` produces a Uint8Array instead of a NodeJs `Buffer` HOT 1
- Access-Control-Allow-Methods not reflected on the response header when integrated with Hono HOT 1
- internal error: entered unreachable code: Expected at least one stalled top-level await HOT 10
- Types don't load if alias in import map isn't exact match of package name when importing `currency.js` from npm HOT 1
- Allow TypeScript files to be imported from npm packages HOT 2
- Astro can't access `process` global HOT 7
- Investigating hung/paused process while dynamically importing async module HOT 11
- `deno serve` doesn't support the second connInfo parameter
- WebSocket `MessageEvent` has `CloseEvent` as its symbol. HOT 2
- feature request: add a `--no-deno-namespace` mode HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deno.