Comments (6)
It looks so, here's the problematic bit:
"scripts": {
"test": "make test && make test-cov",
"blanket": {
"pattern": "//^((?!/node_modules/)(?!/test/).)*$/ig",
"onlyCwd": true,
"data-cover-flags": {
"branchTracking": true
}
},
"travis-cov": {
"threshold": 100
}
},
I'll open a PR to deno_npm
later today.
from deno.
This is now fixed in Deno 1.43.5
from deno.
🙋 The same with npm:joi
:
import joi from "npm:[email protected]";
console.log(joi);
Works with Deno version 1.43.3.
Fails with Deno version 1.43.4:
error: Error getting response at https://registry.npmjs.org/joi for package "joi": invalid type: map, expected a string at line 1 column 18384
at file:///test.ts:1:17
The url https://registry.npmjs.org/joi, does indeed return json that, at the position given in the error message, contains a run-script value that isn't a string, but a json object. It was present in the ancient [email protected]
, removed in the almost as ancient [email protected]
.
- https://github.com/hapijs/joi/blob/v0.1.0/package.json#L30
- https://github.com/hapijs/joi/blob/v0.2.1/package.json
🫚 Root cause?
I suspect this newly found insensitivity to incorrect package.json
run-scripts, was brought in by this entry in the deno 1.43.4 changelog:
fix(npm): handle null fields in npm registry JSON (#23785)
Following that update, leads to this commit in deno_npm
:
That's how far my understanding goes! I'm not familiar enough with serde in rust to know what the previous default behaviour was, that was apparently overridden here. In general though, for npm compatibility, we might want to be more lenient to parts of json from older versions of modules that we don't even need to use?
from deno.
CC @dsherret can you take a look? Seems like a regression.
from deno.
I think this was caused by denoland/deno_npm#47
from deno.
Thank you so much @dsherret and @bartlomieju!
from deno.
Related Issues (20)
- thread 'worker-2' panicked at cli/npm/managed/resolution.rs:231:72: called `Option::unwrap()` on a `None` value HOT 6
- Uncaught SyntaxError: Unexpected reserved word HOT 2
- dynamic import of async module from worker HOT 2
- Make test output slightly easier to read HOT 1
- bug: `JSR package manifest for '@std/uuid' failed to load. Access is denied. (os error 5)` in `std` HOT 2
- `websocket.send()` does not respect the order of messages HOT 1
- `deno publish` to jsr does not resolve `@deno-types="..."`
- `Napi::Buffer<uint8_t>` produces a Uint8Array instead of a NodeJs `Buffer` HOT 1
- Access-Control-Allow-Methods not reflected on the response header when integrated with Hono HOT 1
- internal error: entered unreachable code: Expected at least one stalled top-level await HOT 10
- Types don't load if alias in import map isn't exact match of package name when importing `currency.js` from npm HOT 1
- Allow TypeScript files to be imported from npm packages HOT 2
- Astro can't access `process` global HOT 7
- Investigating hung/paused process while dynamically importing async module HOT 11
- `deno serve` doesn't support the second connInfo parameter
- WebSocket `MessageEvent` has `CloseEvent` as its symbol. HOT 2
- feature request: add a `--no-deno-namespace` mode HOT 3
- Error importing modules after updating dependencies
- Add Error.cause to all Deno.errors instances HOT 6
- Add `navigator.platform` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deno.