Unexpected route order about find-my-way

[dcousens]

It may be that your /33 is static? And that has precedence?

[dcousens]

That appears to be it.

function notFoundHandler () {}
function handler (req, res, params) {
    console.log(params)
}

const FindMyWay = require('find-my-way')

const a = new FindMyWay({ defaultRoute: notFoundHandler })
a.on('GET', '/:userId/foo/bar', handler)
a.on('GET', '/33/:a(^.*$)/:b', handler)
a.lookup({ url: '/33/foo/bar', method: 'GET', headers: {} }, () => {})
// { a: 'foo', b: 'bar' }

const b = new FindMyWay({ defaultRoute: notFoundHandler })
b.on('GET', '/foo/bar/:userId', handler)
b.on('GET', '/:a(^.*$)/:b/33', handler)
b.lookup({ url: '/foo/bar/33', method: 'GET', headers: {} }, () => {})
// { userId: '33' }

It probably tries to take "the most static route" possible.

[mcollina]

yes that’s it. If the doc is unclear, would you mind sending a PR?

[allevo]

Thanks, I'll

[delvedor]

This behavior is correct, we are matching every chunk between the slashes in order.

In particular the parametric routes go before the parametric ones with regexp.

This is true, but we run the check for every node in the current level and not the entire route.