Comments (3)
delucis
commented on June 15, 2024
1
Update: have a fix on a local branch. Will open an upstream PR tomorrow.
from astro-embed.
delucis
commented on June 15, 2024
Thanks for the issue! I noticed this as an accessibility problem too: links without href are not focusable, so the play button can’t be reached with the keyboard.
I think this will need fixing in https://github.com/paulirish/lite-youtube-embed which we depend on — maybe by replacing the link with a button when present.
from astro-embed.
delucis
commented on June 15, 2024
Opened a PR here: paulirish/lite-youtube-embed#177
Let’s see if we get a response and if not we can look to revert the progressive enhancement pattern in astro-embed or use my fork of lite-youtube-embed.
from astro-embed.
Related Issues (20)
- Build fails: Rollup failed to resolve import "linkedom" HOT 4
- @astro-community/astro-embed-vimeo package doesn't list the dependency of @astro-community/astro-embed-utils HOT 1
- Regression in link embedding since 0.7.0 HOT 2
- Youtube embed isn't filling it's container like before when played. HOT 1
- Build not working with SSR adapter HOT 1
- Astro Embed Not Working with Astro v3.0 HOT 5
- Support picking up query string based parameters for MDX integration HOT 2
- Support in RSS feed? HOT 6
- Blank `<p>` added between "Tweet" embeds HOT 2
- How about an embed for Rumble? HOT 4
- The player is over the thumbnail with YouTube HOT 1
- Add Mastodon embed support/demo HOT 1
- request: support for instagram
- Fix: Astro v4 compatibility HOT 3
- Querstion: How can I overview the max-width CSS rule on lite-youtube element?
- Random CLS in Firefox when playing the video HOT 1
- FR: Support Bandcamp embeds
- Issue: Autoplay not working in param HOT 1
- The requested module '/node_modules/cssesc/cssesc.js?v=4e7cd4a1' does not provide an export named 'default'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from astro-embed.