deltanet / adapt-articleblockslider Goto Github PK

Found in first topic of COI.

Trickle is also not appearing when all blocks are complete

Not checking if the extension is enabled causes other extension not to work on the Article, such as Interactive video.

No console errors. Issue can be reproduced in the Understanding Personal Data course.

Reproduced on the following:

1. Samsung S7 edge (android 7.0) on latest chrome.
   The issue is consistent on S7 edge. Moving from portrait to landscape renders the hidden blocks.

2. Chrome dev tools (Galaxy S5) block slider blocks remain hidden.
   This seems to be sporadic, i.e. in chrome dev tools refreshing the page does not always reproduce the issue.

This is because in the framework jquery.resize.js has moved from src/core/js/libraries to src/core/libraries

Getting the following error when trying to build or preview a course with block slider on AT using FW v4.4.0 or above.

Fatal error: Error: ENOENT: no such file or directory, open '/source/adapt/adapt_authoring/temp/5dc1a0eb4e16e44a9c1acca3/adapt_framework/src/core/js/libraries/jquery.resize.js' In module tree: core/js/app extensions/adapt-articleBlockSlider/js/articleBlockSlider extensions/adapt-articleBlockSlider/js/adapt-articleExtension

Clicking through the blocks quickly causes completion issues as blocks/components do not always register as complete when they animate across the screen.

Using browser zoom to > 100% works in Chrome.

The '.article-block-progressbar' class uses variables that are only set in the deltanet default theme.

The jquery.resize file is slightly out of date to the one in Core.

Currently the layout types are customisable in the theme, it would be better to be able to select these in the JSON and eventually in the authoring tool.

The progress location selector (_progressLocation) can be changed selecting top of bottom. The progress icons always appear at the bottom regardless of selection.

CSS seems to be missing for the .is-top and is-bottom classes.

FW v5
Deltanet Block slider fork v4.0.3

On completing a block slider article that has trickle the continue button remains hidden. See topic 1 of First Aid for Non-First Aiders.

It appears that block slider article view is hiding the trickle button as the trickle button gets added as a child of the article model here, trickle button view appears as a component.

_blockSliderSetVisible gets run for the trickle button here

Worth noting that the article containing the block slider remains incomplete, at least 'is_complete' is not added to the article CSS.

Block slider version 4.0.1
Trickle version 5.2.3
Framework version 5.17.6