Audio recording preview not working about react-media-recorder

[gezquinndesign]

Created a PR - #54 to preview audio, the previewStream currently only gets the video tracks, so added a previewAudioStream that does the same thing as previewStream but just for audio.

[DeltaCircuit]

@HBM08 that is by design. It's mentioned in the docs too

Please note that this is a muted stream. This is by design to get rid of internal microphone feedback on machines like laptop.

I just wanted to avoid an unexpected feedback from the internal mic. It would create such a mess 😁

@gezquinndesign thanks for the PR, it does just what it says. Awesome! but having two APIs for the stream is will lead to confusion I guess previewStream and previewAudioStream.

What do you guys think?

[gezquinndesign]

If we only want one way to access the stream in its entirety, then we will have to remove the limitation that is brought about by only returning only the VideoTracks, perhaps we can make it a function with defaults?

getPreviewStream({audio: boolean = false, video: boolean = true})

and return the appropriate altered MediaStream based on the options provided.

Or just return the MediaStream without altering it and warn users to ensure that the audio needs to be muted if using it for a video preview.

As it stands, I don't think it causes too much confusion having 2 separate APIs (previewStream and previewAudioStream) for the stream. It's just an opt-in addition and will ensure there are no breaking changes if people choose to upgrade.

Maybe there's a case for renaming previewStream to previewVideoStream to avoid confusion.

[gezquinndesign]

@0x006F I can alter the PR depending on what you think is best.