Comments (8)
from deltachat-core-rust.
Do you mean types used internally in a function or can this be done in functions that also return std::c_int
that are used as bools? For example dc_aheader_set_from_string()
from deltachat-core-rust.
I've made some notes in the code on some functions that return int but that should return bool instead. Grep for TODO
and bool
.
from deltachat-core-rust.
I'll try that, sounds like a good "first issue".
just need to cast the bools to ints when using them in the public interface in deltachat-ffi/src/lib.rs
So, the API of lib.rs must not be changed? Like,
pub unsafe extern "C" fn dc_msg_has_location(msg: *mut dc_msg::dc_msg_t) -> libc::c_int
?
must still return c_int?
from deltachat-core-rust.
Yes.
from deltachat-core-rust.
Now I did around 15 and there are still around 70 left, and my motivation is decreasing... When and if I continue I'll ping here to avoid that someone else is working on it at the same time.
from deltachat-core-rust.
from deltachat-core-rust.
conversion to bool has happened in many places and is general practise now, no issue needed.
from deltachat-core-rust.
Related Issues (20)
- Detect unsynchronized second device setup HOT 2
- Synchronize custom name for contacts to own devices
- Add device chat message when a self-sent undecryptable message is sent HOT 2
- Move display names to protected headers in verified chats HOT 8
- Encrypt MDNs (read receipts)
- feat: Add nix derivation HOT 1
- docs worsening: "Constants" page removed from c.delta.chat HOT 2
- SecureJoin: include keydata in QR code HOT 4
- no contact names for contact-IDs used in mailinglists' reaction details HOT 16
- send bcc-self even if delete from server is set to "at once" HOT 1
- Messages get stuck in Downloading... state
- Flaky securejoin tests
- SMTP-Forwarded read receipts should not turn into new chats HOT 7
- Add support for IMAP METADATA
- Test `test_verified_group_vs_delete_server_after` is flaky HOT 4
- vCard-based address book import API
- vCard-based address book export API
- Add vCard viewtype
- deltachat-rpc-server 1.133.1 binaries fail to setup accounts via QR code on Linux HOT 12
- `get_protected_chat` in Python bindings is flaky HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deltachat-core-rust.