Replace types that use only 0 and 1 with bool about deltachat-core-rust

[dignifiedquire]

functions too I would argue, just need to cast the bools to ints when using them in the public interface in deltachat-ffi/src/lib.rs

…

On 1. May 2019, 12:09 +0200, Lars-Magnus Skog ***@***.***>, wrote: Do you mean types used internally in a function or can this be done in functions that also return std::c_int that are used as bools? For example dc_aheader_set_from_string() — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[ralphtheninja]

Do you mean types used internally in a function or can this be done in functions that also return std::c_int that are used as bools? For example dc_aheader_set_from_string()

[ralphtheninja]

I've made some notes in the code on some functions that return int but that should return bool instead. Grep for TODO and bool.

[Hocuri]

I'll try that, sounds like a good "first issue".

just need to cast the bools to ints when using them in the public interface in deltachat-ffi/src/lib.rs

So, the API of lib.rs must not be changed? Like,
pub unsafe extern "C" fn dc_msg_has_location(msg: *mut dc_msg::dc_msg_t) -> libc::c_int?
must still return c_int?

[ralphtheninja]

Yes.

[Hocuri]

Now I did around 15 and there are still around 70 left, and my motivation is decreasing... When and if I continue I'll ping here to avoid that someone else is working on it at the same time.

[hpk42]

keep up the good work, @Hocuri, it's much appreciated :) If i wouldn't be deep in other finance-related buereaucracy i'd try out engaging with Rust buereaucracy as it provides maybe more hope of being useful ;)

…

On Fri, May 10, 2019 at 13:33 +0000, Hocuri wrote: Now I did around 15 and there are still around 70 left, and my motivation is decreasing... When and if I continue I'll ping here to avoid that someone else is working on it at the same time. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #18 (comment)

[hpk42]

conversion to bool has happened in many places and is general practise now, no issue needed.