Graphics glitches in wasm32 target about peanut-gb

[lesleyrs]

Never mind I forgot to allocate memory for cart_ram. Fixed now it works :D

[lesleyrs]

@deltabeard I'll leave a message here once I make it public again, just trying to finish it up. Not sure if it meets your expectations because I haven't worked out how to optimally interact with wasm in JS (I just turned every interaction into a function for simplicity, but I guess you should be able to change variables etc directly).

It's working well though which is my goal, the pixel scaling with image-rendering: pixelated; was fixed by this issue too.

[deltabeard]

Nice to hear you got it working! Whilst your repo isn't available/public anymore (I was interested in the WASM implementation without emscripten...) be careful not to include non-redistributable ROMs (like Pokemon Red) in your repo. You can use open source ROMs instead to prove your implementation. 😃

[lesleyrs]

It turns out you actually can't use variables from wasm in js, only call functions and access memory directly. Took longer than expected because I end up implementing almost all features, behold: https://github.com/lesleyrs/web-gbc. I'm quite happy with the results, I actually just let the main function in wasm exit and just call the 2 required functions in JS loop.

BTW using your cgb branch shows this warning message in polished crystal about emulator bugs: https://github.com/Rangi42/polishedcrystal/blob/3c769991deb0a0756d7e9accd3f6a496003c7689/data/text/common.asm#L3340

Code here: https://github.com/Rangi42/polishedcrystal/blob/master/home/vba.asm Is this a hard or easy fix to avoid the warning?