Coder Social home page Coder Social logo

Destructors about inject HOT 4 CLOSED

defval avatar defval commented on July 18, 2024
Destructors

from inject.

Comments (4)

yoyofx avatar yoyofx commented on July 18, 2024

I think used interface better. such as IDestruct interface has a OnDestruct method.

from inject.

defval avatar defval commented on July 18, 2024

@maxzhang1985 I'd prefer to separate the object lifecycle management functions from the object functionality. Also, interface forces to wrapping standard library types.

I start to implement the Provider interface in v2 for advanced providing. Maybe, extended ProviderDestructor or ProviderCloser interface will be the best option.

type Provider interface {
    Identity() Identity
    Construct() (interface, error)
}

type ProviderDestructor interface {
    Destruct() error
}

I didn't have time to test it. But here a usage example.

I'm still thinking about it.

from inject.

defval avatar defval commented on July 18, 2024

I came to the conclusion that a better option is to support an optional cleanup function as a result of the constructor (like in google/wire).

For example:

func provideFile(log Logger, path Path) (*os.File, func(), error) {
    f, err := os.Open(string(path))
    if err != nil {
        return nil, nil, err
    }
    cleanup := func() {
        if err := f.Close(); err != nil {
            log.Log(err)
        }
    }
    return f, cleanup, nil
}

from inject.

defval avatar defval commented on July 18, 2024

Implemented in #26

from inject.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.