Comments (4)
I think used interface better. such as IDestruct interface has a OnDestruct method.
from inject.
@maxzhang1985 I'd prefer to separate the object lifecycle management functions from the object functionality. Also, interface forces to wrapping standard library types.
I start to implement the Provider interface in v2
for advanced providing. Maybe, extended ProviderDestructor
or ProviderCloser
interface will be the best option.
type Provider interface {
Identity() Identity
Construct() (interface, error)
}
type ProviderDestructor interface {
Destruct() error
}
I didn't have time to test it. But here a usage example.
I'm still thinking about it.
from inject.
I came to the conclusion that a better option is to support an optional cleanup function as a result of the constructor (like in google/wire).
For example:
func provideFile(log Logger, path Path) (*os.File, func(), error) {
f, err := os.Open(string(path))
if err != nil {
return nil, nil, err
}
cleanup := func() {
if err := f.Close(); err != nil {
log.Log(err)
}
}
return f, cleanup, nil
}
from inject.
Implemented in #26
from inject.
Related Issues (15)
- Visualize dependency graph HOT 2
- Check that provider implements interface
- v2: Extended provider
- Graph visualization
- v2: Readme
- v2: Embed parameters HOT 1
- v2: Cleanup
- v2: Prototype providing
- v2: Optional parameters
- Cleanup ordering
- Cleanup with prototypes
- Resolving named interfaces as map[<name>]<interface>
- Container.Invoke() implementation
- Replacing already defined provider HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inject.