Add support for Arduino about vscode-dash

[akdir]

I would like to add Arduino Support for this extension @deerawan. So I already looked at it and it seems like VSCode sees Arduino .ino file as a .cpp file, because the output of the vscode.window.activeEditor.document.languageId is cpp for ino files. That means you can add Arduino support by adding arduino as a key to the value cpp in the package.json file. But adding a new key/value pair for arduino itself will not work, because VSCode sees Arduino files as cpp files.

So should I just add it to the cpp value? I would like to hear from you @deerawan.

[akdir]

Now I can also fix this by adding this little if statement in the function getDocSets() in extension.ts to force it to get the arduino languageId correctly.

So then the function will be:

/**
 * Get docset configuration
 *
 * @param {string} languageId e.g javascript, ruby
 * @return {string}
 */
function getDocsets(): string[] {
  const editor = getEditor() as TextEditor;
  const fileName = path.basename(editor.document.fileName);
  const languageId = editor.document.languageId;

  const fileNameDocsets = getFileNameDocsets(fileName);
  var languageIdDocsets = getLanguageIdDocsets(languageId);

  // To get arduino fileName correctly, because VSCode editor.document.languageId is cpp for arduino(ino) files!
  if (fileName.split('.').pop() == 'ino') {
    languageIdDocsets = getLanguageIdDocsets('arduino');
  }

  // prioritize docset matching by file name then language id
  return [...fileNameDocsets, ...languageIdDocsets];
}

What do you think is better @deerawan. Maybe there is another way that I do not know of, but that is the only way I could add support for Arduino.

[deerawan]

Hi @akdir, just noticed your message. Thank you.

Let me do some investigation.

[deerawan]

@akdir have you installed the extension https://marketplace.visualstudio.com/items?itemName=vsciot-vscode.vscode-arduino? This is in order to detect the language ID correctly.

[akdir]

@akdir have you installed the extension https://marketplace.visualstudio.com/items?itemName=vsciot-vscode.vscode-arduino? This is in order to detect the language ID correctly.

@deerawan , Yes that is the first thing I did. That did not change the vscode.window.activeEditor.document.languageId output, it is still cpp for ino files. So I thought maybe VSCode sees ino files just as CPP files, because afterall the "programming language" Arduino is based on C/C++ but has some special functions to interact with Analog and Digital I/O.

[deerawan]

interesting, maybe we can do the alternative way by detecting the filename https://github.com/deerawan/vscode-dash#file-name-to-docset-matching