Someone said this function (mapset.Iter) has bug, but I don't know where is it. Plz tell me about golang-set

[deckarep]

Yes it is a bug where if you don't fully consume from the channel and break early, you will experience a leaked goroutine.

This is why there is another function called Iterator which allows you to signal that you're done early when iterating and notify the channel.

The better solution which is on my list is to have Iterator take a cancelable Context which is the better pattern for this type of scenario.

I'll be implementing it soon.

[dayuoba]

if someone outside, has the returned channel and he does not consume all the channel msgs, the lock has the potential of being a deaded lock

[gitbufenshuo]

• 没有停止机制

• 我就不明白了，一个【小写】的结构体拥有一个【大写】的方法这种事情就这么好玩？【应该尽量不这么写，🙃😆】

[andy-zhangtao]

I think we should analysis code with application context. Simply looks this function seems right, no bug here.

[deckarep]

Here is the related thread: #33

[lkiversonlk]

BTW, it's not the common usage pattern of Iterator

[gravitywp]

@deckarep Thanks for your reply. Seem to be the right answer to me. Should I close the issue?

[deckarep]

Sure thanks!

…

On Sat, Jul 1, 2017 at 10:53 PM Patrick ***@***.***> wrote: @deckarep <https://github.com/deckarep> Thanks for your reply. Seem to be the right answer to me. Should I close the issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#50 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMP7sWkUTg8ZnP82fNPM6uxBY8-QgHfks5sJzBugaJpZM4OKFGy> .