Unit Tests for Blockchain, and CAS Clients about sidetree

[OR13]

Related, I pulled down the latest and the current tests were failing (the did document id was not correct after the create request).

I fixed the test and added travis ci to my fork.

Having CI tests will really help encourage contributions and increate confidence that contributors are not breaking things.

https://travis-ci.org/transmute-industries/sidetree-core/builds/442307014

I'm not a member of this github org yet, but if someone can turn on travis ci for this repo, I'm happy to open a PR with the passing tests and ci changes.

[OR13]

I'd be interested in adding these tests once some CI system is hooked up.

[sylar217]

@thehenrytsai do we want to have a travis setup or a Visual Studio CI setup for this? Both seems fine to me

[thehenrytsai]

I will have to look into the issue in unit tests further because the same test passes on my end, it would be great if @sylar217 you can see if the unit test passes on your end?

Definitely for having CI setup, just haven't got around to it. Will not grab this issue just yet as I want to close other issues I grabbed first, will come around to this ASAP though, as I agree CI will encourage contribution!

[OR13]

@thehenrytsai Can I open a pull request that adds Travis CI and runs the current test suite?

[thehenrytsai]

@OR13, yes please! I can setup Travis CI if needed.

[OR13]

@thehenrytsai #41

Done.

[OR13]

I'm not exactly sure what format we want to be using for mocking these clients, but here is one approach:

transmute-industries@5f2515f

Happy open a PR or restructure these tests based on feedback.

[thehenrytsai]

Thanks @OR13, I was not able to repro the unit test issue on a separate Windows environment, but just managed to repro on a mac, will debug and provide a fix, then merge in your PR. Then I'll look at the branch for client mocking code.

[thehenrytsai]

Turned out to be test JSON file stored on Windows vs Linux being different which causes the buffer to be different (Windows uses \n\r, Linus uses \n). Will submit a fix.

[thehenrytsai]

Hi @OR13, your pull request on Travis CI is merged, thanks again!

I took a look at your approach for mocking the CAS and blockchain servers and they look fine for the purpose of unit testing. Would be great if you can open a PR.

Regarding the exact response schema, they are already intended to be somewhat chain agnostic, and are defined in the implementation documentation under Blockchain/CAS REST API sections. They are subject to change as we refine the design and implementation, but you can follow that for now.

I've made some comments on your current commits.

[thehenrytsai]

Much more unit tests have been added since then. Also added #212 to boost code coverage to near 100%.