Comments (6)
$ cat /tmp/debops_ansible_version_path_handling.patch
--- debops.orig 2018-01-15 13:05:04.000000000 -0700
+++ debops 2018-01-15 13:24:30.000000000 -0700
@@ -106,7 +106,7 @@
plugin_type = plugin_type+"_plugins"
defaults[plugin_type] = PATHSEP.join(custom_paths(plugin_type))
- if ansible.__version__ >= "1.7":
+ if ansible.__version__ >= "1.7" and ansible.__version__ < "2.0":
# work around a bug obviously introduced in 1.7, see
# https://github.com/ansible/ansible/issues/8555
if ' ' in defaults[plugin_type]:
from debops-tools.
Thanks for the bug report! Unfortunately I don't have a macOS host handy to test this... Could you check if your fix works with the version currently present in the debops/debops
repository?
If not, that's fine - I can apply the fix and it will probably work. I plan to release a new version with Python 3 support in a few days.
from debops-tools.
Is this good enough of a test?
$ PYTHON_PATH=../debops/lib/debops-tools/debops ; rm ansible.cfg && ../debops/lib/debops-tools/bin/debops -l ans.ap
It still generates the same ansible.cfg with the extra quote characters that ansible chokes on.
from debops-tools.
And it works fine with your fix?
from debops-tools.
Testing...
$ patch < /tmp/debops_ansible_version_path_handling.patch
patching file debops
Hunk #1 succeeded at 119 (offset 13 lines).
With patched version run with same command above.
- Verified not extra quotes in paths
- Verified 'debops -l testhost' completed
Also, the python path above was likely not right. Re-ran both cases with PYTHON_PATH=../debops/lib/debops-tools
Same results, unpatched fails, patched works
from debops-tools.
@luken Thanks for checking this. In that case I'm gonna apply your patch, it should be fixed in the next release.
from debops-tools.
Related Issues (20)
- Check code signatures
- Move `debops.keyring` Python module into this repo
- Refactor Python modules
- Signed PyPI releases
- debops-update: fails when ansible_managed contains variables
- Document subcommands
- Please enlighten me how to workaround this particular failure I noted HOT 12
- MS Windows Support? HOT 5
- Update http://debops.org/ to https://debops.org/ in repo description HOT 1
- README randomly lists 1 out of 3 dependencies
- provide a commented example config of how to use template_src HOT 1
- debops-padlock unusable with encfs > 1.9 HOT 6
- Raspbian detected as Debian HOT 4
- debops-update has no --dry-run argument HOT 2
- Debops inserts faulty Ansible ppa sources into sources.list HOT 1
- ERROR! Unexpected Exception: invalid syntax (profile_tasks.py, line 68)
- Broken Link for "Getting Started Guide" HOT 3
- wrong pathes for lookup_plugins in ansible.cfg HOT 5
- Bootstrap: Variables from group_vars/all/bootstrap.yml not getting picked up HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from debops-tools.