quoting directories with spaces in ansible.cfg breaks with 2.7 about debops-tools

[luken]

$ cat /tmp/debops_ansible_version_path_handling.patch

--- debops.orig	2018-01-15 13:05:04.000000000 -0700
+++ debops	2018-01-15 13:24:30.000000000 -0700
@@ -106,7 +106,7 @@
         plugin_type = plugin_type+"_plugins"
         defaults[plugin_type] = PATHSEP.join(custom_paths(plugin_type))

-        if ansible.__version__ >= "1.7":
+        if ansible.__version__ >= "1.7" and ansible.__version__ < "2.0":
             # work around a bug obviously introduced in 1.7, see
             # https://github.com/ansible/ansible/issues/8555
             if ' ' in defaults[plugin_type]:

[drybjed]

Thanks for the bug report! Unfortunately I don't have a macOS host handy to test this... Could you check if your fix works with the version currently present in the debops/debops repository?

If not, that's fine - I can apply the fix and it will probably work. I plan to release a new version with Python 3 support in a few days.

[luken]

Is this good enough of a test?

$ PYTHON_PATH=../debops/lib/debops-tools/debops ; rm ansible.cfg && ../debops/lib/debops-tools/bin/debops -l ans.ap

It still generates the same ansible.cfg with the extra quote characters that ansible chokes on.

[drybjed]

And it works fine with your fix?

[luken]

Testing...

$ patch < /tmp/debops_ansible_version_path_handling.patch
patching file debops
Hunk #1 succeeded at 119 (offset 13 lines).

With patched version run with same command above.

• Verified not extra quotes in paths
• Verified 'debops -l testhost' completed

Also, the python path above was likely not right. Re-ran both cases with PYTHON_PATH=../debops/lib/debops-tools

Same results, unpatched fails, patched works

[drybjed]

@luken Thanks for checking this. In that case I'm gonna apply your patch, it should be fixed in the next release.