Crash on timing about sharptimer

[PatricNox]

//PLUGIN
sharptimer_hostname                                 A SharpTimer Server   // Default Server Hostname. Default value: A SharpTimer Server
sharptimer_autoset_mapinfo_hostname_enabled         false                                   // Whether Map Name and Map Tier (if available) should be put into the hostname or not. Default value: false
sharptimer_mysql_enabled                            true                                   // Whether player times should be put into a MySQL database by default or not. Default value: false


//MISC
sharptimer_connectmsg_enabled                       true                                    // Whether connect/disconnect messages are enabled by default or not. Default value: true
sharptimer_connect_commands_msg_enabled             true                                    // Whether commands on join messages are enabled by default or not. Default value: true
sharptimer_kill_pointservercommand_entities         true                                    // If "true" the plugin will kill all point_servercommand ents on map start (necessary to make xplay maps playable. 🖕 @xplay). Default value: true
sharptimer_custom_map_cfgs_enabled                  false                                    // Whether Custom Map .cfg files should be executed for the corresponding maps (found in cfg/SharpTimer/MapData/MapExecs/kz_example.cfg). Default value: true
sharptimer_command_spam_cooldown                    0.5                                     // Defines the time in seconds between commands can be called. Default value: 0.5
sharptimer_remove_legs                              true                                    // Whether Legs should be removed or not. Default value: true
sharptimer_remove_collision                         true                                    // Whether player collision should be removed or not. Default value: true
sharptimer_remove_damage                            true                                    // Whether dealing damage should be disabled or not. Default value: true
sharptimer_remove_crouch_fatigue                    true                                    // Whether the player should get no crouch fatigue or not. Default value: true
sharptimer_trigger_push_fix                         false                                   // When enabled all trigger_push ents will only push once OnStartTouch. Default value: false
sharptimer_hide_all_players                         false                                   // Whether all players should be hidden or not. Default value: false


//TIMED MESSAGES
sharptimer_ad_enabled                               true                                    // Whether timed hint messages are enabled by default or not. Default value: true
sharptimer_ad_timer                                 120                                     // Interval how often the timed hint messages shall be printed to chat. Default value: 120


//SPEED
sharptimer_use2Dspeed_enabled                       true                                    // Whether the plugin should use 2D speed instead of 3D speed
sharptimer_disable_telehop                          true                                   // Whether the players should lose all speed when entering a teleport map trigger or not. Default value: false
sharptimer_max_start_speed_enabled                  true                                    // Whether the players speed should be limited on exiting the starting trigger or not. Default value: true
sharptimer_max_start_speed                          320                                     // Defines max speed the player is allowed to have while exiting the start trigger. Default value: 320
sharptimer_force_knife_speed                        true                                   // Whether the players speed should be always knife speed regardless of weapon held. Default value: false
sharptimer_forced_player_speed                      250                                     // Speed override for sharptimer_force_knife_speed. Default value: 250


//HUD AND COLORS
sharptimer_chat_prefix                              ●                            // Default value of chat prefix for SharpTimer messages. Default value: SharpTimer
sharptimer_hud_primary_color                        #00FF00                                 // Primary Color for Timer HUD (you can use hex codes too). Default value: #00FF00 (green)
sharptimer_hud_secondary_color                      #FFA500                                 // Secondary Color for Timer HUD (you can use hex codes too). Default value: #FFA500 (orange)
sharptimer_hud_tertiary_color                       #FFFFFF                                 // Tertiary Color for Timer HUD (you can use hex codes too). Default value: #FFFFFF (white)
sharptimer_enable_timer_hud                         true                                    // If Timer Hud should be globally enabled or not. Default value: true
sharptimer_enable_keys_hud                          true                                    // If Keys Hud should be globally enabled or not. Default value: true
sharptimer_override_beam_colors_enabled             false                                   // Whether Trigger Beams should use the colors below or not. If false plugin uses sharptimer_hud_primary_color
sharptimer_start_beam_color                         #00FF00
sharptimer_end_beam_color                           #FF0000


//BASIC COMMANDS
sharptimer_respawn_enabled                          true                                    // Whether !r is enabled by default or not. Default value: true
sharptimer_top_enabled                              true                                    // Whether !top is enabled by default or not. Default value: true
sharptimer_rank_enabled                             true                                    // Whether !rank is enabled by default or not. Default value: true
sharptimer_goto_enabled                             true                                   // Whether !goto is enabled by default or not. Default value: false


//GLOBAL RANK POINTS
sharptimer_global_rank_points_enabled               true                                   // Whether the plugin should reward players with global points for completing maps. MySQL Requierd. Default value: false
sharptimer_display_rank_tags_chat                   true                                    // Whether the plugin should display rank tags infront of players names in chat or not. Default value: true
sharptimer_display_rank_tags_scoreboard             true                                    // Whether the plugin should display rank tags infront of players names in scoreboard or not. Default value: true
sharptimer_global_rank_free_points_enabled          true                                    // Whether the plugin should reward players with free points for completing maps without beating their PB (31xMapTier). Default value: true
sharptimer_global_rank_max_free_rewards             20                                      // How many times the player should recieve free 'participation' points for finishing the map without a new PB. Default value: 20


//REPLAYS
sharptimer_replays_enabled                          false                                   // Whether replays should be enabled or not. This option might be performance taxing and use more ram & cpu. Default value: false


//CHECKPOINTS/SAVELOC
sharptimer_checkpoints_enabled                      true                                   // Whether !cp/saveloc, !tp/loadloc, and !prevcp/prevloc & !nextcp/nextloc are enabled by default or not. Default value: false
sharptimer_remove_checkpoints_restrictions          false                                   // Whether checkpoints/locs should save in the air with the current player speed (enable for surf). Default value: false
sharptimer_checkpoints_only_when_timer_stopped      false                                   // Will only allow checkpoints/locs if timer is stopped using !timer


//DEBUGGING
sharptimer_debug_enabled                            false                                   // Whether debug console messages should be printed or not. Default value: false

[deafps]

try logging with sharptimer_debug_enabled true so identifying where exactly the issue comes from is easier

[PatricNox]

try logging with sharptimer_debug_enabled true so identifying where exactly the issue comes from is easier

it is indeed happening the moment a new time is being saved into the db.
tried again with it on,

here is a example:

https://youtu.be/Cg-lB89BbOQ?t=26

I think this started to happen after i changed sharptimer_checkpoints_only_when_timer_stopped to false but not sure

[PatricNox]

Im suspecting it happens cus the SQL insert is trying to occur before timer is stopped

Everytime someone beats the map, the server crashes when using SharpTimer :(

[deafps]

ngl i haven't heard of this issue from someone else

[PatricNox]

ngl i haven't heard of this issue from someone else

Yep I got no idea even tried to reinstall it.

I've debugged it and adding a return true here seems to prevent it to crash

https://github.com/DEAFPS/SharpTimer/blob/main/src/PlayerUtils.cs#L40

why? idk

[deafps]

ngl i haven't heard of this issue from someone else

Yep I got no idea even tried to reinstall it.

I've debugged it and adding a return true here seems to prevent it to crash

https://github.com/DEAFPS/SharpTimer/blob/main/src/PlayerUtils.cs#L40

why? idk

why would you want to return true when the player is null? this will create more issues than it fixes.

[PatricNox]

ngl i haven't heard of this issue from someone else

Yep I got no idea even tried to reinstall it.
I've debugged it and adding a return true here seems to prevent it to crash
https://github.com/DEAFPS/SharpTimer/blob/main/src/PlayerUtils.cs#L40
why? idk

why would you want to return true when the player is null? this will create more issues than it fixes.

It was done and reported as a way to help you help me identify the issue, this was obviously not suggested as a fix.

Edit: I added stacktrace for debug and got this response within the said method

object reference not set to an instance of an object

So yes I suppose it is indeed the player that does not get set properly somewhere in the line of OnTimerStop