Bug: Undocumented backwards-incompatible change of empty "page" parameter introduced in 6.4.0 about pagy

[ddnexus]

@clemens FYI

The page variable is normally extracted from the params and sent to the Pagy.new, which can do its thing with normalization. However, certain extras need the page vars as a positive integer BEFORE creating the pagy object, so in that case the normalization comes too late.

The pagy_get_page takes care of the normalization of the page in all cases now, before creating the pagy object.

[ddnexus]

@clemens Thank you for the report and the complete description of bug and cause!

I remember there was a reason for the .to_i, but I don't remember which one ATM. It was something related to multiple overriding or sharing of the same method or something... I will investigate.

I will have to add a test, because right now nothing fails for the bug (not sure whether I also messed up the test for it).

Happy to provide a PR if desirable.

Thank you, that's always desiderable. However in this particular case I need some generalized deep thinking before I can fully understand the implications and fix it without breaking something else somewhere, somehow, sometime 🤔

[ddnexus]

8.2.1