Comments (5)
Preliminary work completed, information box now pops up and displays pitch information for neumes + custos.
TODO:
-Refactor into its own js file
-Somehow get clef information (ID is missing since its not a separate XML element)
-Get grouping name from verovio (hard? since its a map)
from neon.
By here everything is in its own file and we can get information for neumes, clefs, and custos.
We have two general functions added to vrv::Toolkit. Clef information is gotten through the staffDef tag in a bit of a roundabout way, but it doesn't seem there's a more straightforward way.
Neume grouping names are in a map local to InfoController.js
as to not add a neon-specific function to verovio.
@zoemcl can you think of anything left to do for this issue?
from neon.
Only thing left to do would be to display the retrieved information in a nice and consistent way but that is purely a cosmetic issue.
from neon.
Tried to make it look more like the info box in Neon.js in 0ead422.
from neon.
Looks good!
from neon.
Related Issues (20)
- [Neon staging] Merging two staves makes all staves misbehave
- Use `wasm` version of Verovio instead of customized toolkit for development
- [Neon staging] Files don't order themselves automatically on the dashboard HOT 8
- [Neon staging] Custodes misbehaving HOT 2
- [Neon staging] Reloading the page makes all glyphs disappear HOT 8
- [Neon staging] Some files say "unknown" and never appear... but I don't know why :( HOT 2
- [Neon staging] New elements input on folio automatically assign to one of only 3-4 staves on the page
- [Neon staging] Moving a neume component makes its neume move up a step or two HOT 2
- [Neon staging] glyphs on staff don't get moved after dragging the staff
- [Neon staging] Dragging staff makes ncs and accids jump horizontally HOT 1
- [Neon staging]Inserted neume components don't show HOT 1
- tutorial video links don't work? HOT 4
- Old Salzinnes files have accidentals that don't appear in Neon HOT 3
- [Neon staging] Custodes added after clef octave displacement appear an octave too high/low HOT 3
- [Neon staging] Liquescents and obliques look weird HOT 6
- Request to change the notification when the user tries to ungroup a syllable that is a single neume
- Display `<l>` element
- [Neon staging] Changing a head shape only works after inputting another glyph
- Request: allow the bounding box circles to be bigger as well as smaller
- C clefs appear to be centred around C3 rather than C4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neon.