Coder Social home page Coder Social logo

Comments (5)

dddeeemmmooonnn avatar dddeeemmmooonnn commented on August 10, 2024

Hello.
You can extend dddeeemmmooonnn\NovaMulticolumnFilter\NovaMulticolumnFilter and override apply method

from nova-multicolumn-filter.

bilfeldt avatar bilfeldt commented on August 10, 2024

True, but that would require me to override the apply method, which will break in case of future field types being implemented.

Are you open for a PR for this operator? Or alternatively, might I suggest refactoring the apply method to use a new applySingle in the foreach (json_decode($value, true) as $val) {} loop. In that case, people can simply extend the applySingle method to call their own method if a custom filter is provided and otherwise the parent applySingle.

from nova-multicolumn-filter.

dddeeemmmooonnn avatar dddeeemmmooonnn commented on August 10, 2024

I think then it is better to add a new option for the column - the name of the method by which to process the column.
Then you will need to add the method and specify it in the options
I'll do it later today

ofc open for PR

from nova-multicolumn-filter.

bilfeldt avatar bilfeldt commented on August 10, 2024

@dddeeemmmooonnn that would be a nice refactoring. When added please let me know and I will check if I can implement this feature, hopefully as a PR. I think it would be a neat addon 👍

from nova-multicolumn-filter.

dddeeemmmooonnn avatar dddeeemmmooonnn commented on August 10, 2024

0.5 update

from nova-multicolumn-filter.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.