Validation not working about conditional-container

[milewski]

uhm.. can you do a quickly test,

Instead of using creationRules and updateRules use just rules if it works I think I know what may be wrong and I can issue a quickly fix...

[milewski]

Hi @nemrutco I just doubled checked.. it does work with creationRules and updateRules did you import use HasConditionalContainer; ?

i just tried

 ConditionalContainer::make([
                Text::make(__('Username'), 'username')->rules('required'),
            ])->if('role != 3'),

and it still doesn't work.

Yes i imported use HasConditionalContainer

[milewski]

Is this how you are using it?

public function fields(Request $request)
{
    return [

        Select::make(__('Role'), 'role')
              ->options([
                  1 => 'A',
                  2 => 'B',
                  3 => 'C',
              ]),

        ConditionalContainer::make([

            Text::make(__('Name'), 'name')
                ->creationRules('required', 'max:255')
                ->updateRules('required', 'max:255'),

        ])->if('role != 3'),

    ];
}

role needs to be an actual field in your model otherwise it wont be able to detect it

If its not.. you can try something like this: #7 (comment)

public function fields(Request $request)
    {
        return [
            ID::make()->sortable()
                ->onlyOnForms(),

            BelongsTo::make(__('Role'), 'role')->withMeta([
                'belongsToId' => $this->role->id ?? null
            ]),

            Text::make(__('Name'), 'name')->onlyOnIndex(),

            ConditionalContainer::make([
                Text::make(__('Username'), 'username')
                    ->sortable()
                    ->creationRules('required', 'unique:users,username', 'max:254', 'alpha_dash')
                    ->updateRules('sometimes', 'required', 'unique:users,username,{{resourceId}}', 'max:254', 'alpha_dash'),

                Password::make(__('Password'), 'password')
                    ->onlyOnForms()
                    ->creationRules('required', 'string', 'min:8')
                    ->updateRules('sometimes', 'required', 'string', 'min:8'),
            ])->if('role != 3'),

            Text::make(__('Employee Number'), 'employee_number')
                ->sortable()
                ->rules('required', 'integer'),

            BelongsToMany::make(__('Stores'), 'stores')
                ->searchable(),

            MorphOne::make(__('Card'), 'card'),

            BelongsTo::make(__('Profile'), 'profile', Profile::class)
                ->inline()
                ->rules('required')
                ->hideFromIndex(),

            HasMany::make(__('Sales'), 'sales'),
        ];
    }

role is an actual field. And i just tried another field as well.

            ConditionalContainer::make([
                Text::make(__('Employee Number'), 'employee_number')
                    ->sortable()
                    ->rules('required', 'integer'),
            ])->if('role != 3'),

still not working.

Did you mean role has to be a field in model table? Because role is relationship in my case.

[milewski]

@nemrutco fixed on version v1.1.3, the problem was with the BelongsTo and the != operator, on the way I found it had the same issue with other operators as well >= <= != !== it's now fixed, try again

Fixed! Thank you.

Another issue related to this:
when password field is nullable, it submits password to db as null and db updates the value to null (db password field is nullable) but when i use without ConditionalContainer, null value does not update db so old password stays. Why does it update db when it is nullable? it should ignore the field.

Password::make(__('Password'), 'password')
                    ->onlyOnForms()
                    ->creationRules('required', 'string', 'min:8')
                    ->updateRules('sometimes', 'nullable', 'string', 'min:8')

[milewski]

Please open another issue with this otherwise it may get forgotten in here