Crash when starting airnotifier.py about airnotifier

[mouneyrac]

I suspect it's because I didn't have a certfile.

[mouneyrac]

ok fixed:

    for instanceid in range(0, conns):
        if 'certfile' not in app:
            app['certfile'] = ''
        if 'keyfile' not in app:
            app['keyfile'] = ''
        apn = APNClient(app['environment'], app['certfile'], app['keyfile'], app['shortname'], instanceid)
        apnsconns[app['shortname']].append(apn)

[dcai]

I wrote something similar :-)

•    for instanceid in range(0, conns):
  

•        apn = APNClient(app['environment'], app['certfile'], app['keyfile'], app['shortname'], instanceid)
  

•        apnsconns[app['shortname']].append(apn)
  

•    if 'certfile' in app and 'keyfile' in app and 'shortname' in app:
  

•        for instanceid in range(0, conns):
  

•            apn = APNClient(app['environment'], app['certfile'], app['keyfile'], app['shortname'], instanceid)
  

•            apnsconns[app['shortname']].append(apn)
  

if certfile and keyfile don't exist, the APNClient shouldn't be started.

[mouneyrac]

ah I'm about to commit my fix

[mouneyrac]

ok I let you commit yours I think it's better to not start anything

[dcai]

Your commit should be:

    for instanceid in range(0, conns):
        if 'certfile' in app and 'keyfile' in app:
            apn = APNClient(app['environment'], app['certfile'], app['keyfile'], app['shortname'], instanceid)
            apnsconns[app['shortname']].append(apn)

[dcai]

Just committed, let me know if it fails again :)

[mouneyrac]

It works closing. Thanks dongsheng.