barchart brush selection mask covers top margin about dc.js

[NickQiZhu]

This is definitely a bug; will address it in 0.9.

On Fri, Aug 17, 2012 at 4:27 PM, jeroenooms [email protected]:

[image: bars]https://a248.e.akamai.net/camo.github.com/9f7bff155e5f0b6827c72f76c5caa9c53560e595/687474703a2f2f692e696d6775722e636f6d2f564d6a53312e706e67

The blue mask that overlays the selected/blue area (i'm not sure what it
is called) is covering the top-margin as well. I don't think this was the
case in version 0.7. I created a very big top margin in the example above
to show the issue.

It is probably better if it does not cover the top-margin area, just like
it does not cover the left, right and bottom margin of the chart.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35.

[NickQiZhu]

fixed in v0.9

[jeroen]

Cool :-) Could you push this fix?

[NickQiZhu]

I actually took your advice, since I got similar feedback from other folks, creating separate branch for next release while keeping master stable. So all 0.9 related changes on currently on 0.9 branch. Unfortunately continuous delivery is just not something most people expect from a open source project =)

[jeroen]

Cool! Could you push the the fixes to this branch then?

[NickQiZhu]

Its pushed. Let me know if you dont see it.

On Tue, Aug 28, 2012 at 2:50 PM, jeroenooms [email protected]:

Cool! Could you push the the fixes to this branch then?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-8102726.

[jeroen]

Ah cool thanks.

On Tue, Aug 28, 2012 at 9:24 PM, Nick Zhu [email protected] wrote:

Its pushed. Let me know if you dont see it.

On Tue, Aug 28, 2012 at 2:50 PM, jeroenooms [email protected]:

Cool! Could you push the the fixes to this branch then?

—
Reply to this email directly or view it on GitHub<
https://github.com/NickQiZhu/dc.js/issues/35#issuecomment-8102726>.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-8103836.