_chart.anchor(a) should accept dom arguments about dc.js

[NickQiZhu]

Hi Christophe,

Thanks for the suggestion. If you are trying to draw the chart on an
already selected node through d3 then you can use the root() to manually
set the root after creating the chart, or if you are trying to overlay a
chart on an existing chart (which is what I think you are doing with the
code example) then you can use the compositeChart to achieve that.

Cheers,

Nick

On Thu, Aug 2, 2012 at 3:44 PM, christophe geiser <
[email protected]

wrote:

Hi,
Thanks for ver 0.6.0, good work.

Just one thing to mention here (just before I go on holiday - not much
time to submit propose a push) : I would suggest that _chart.anchor accept
a dom arguments so that you can call the creation of a chart on a node that
has already been selected.

_chart.anchor = function(a) {
        if (!arguments.length) return _anchor;
        if (a instanceof Object) {
            _anchor = a.anchor();
            _root = a.root();
        } else {
            _anchor = a;
            _root = d3.select(_anchor);
            dc.registerChart(_chart);
        }
        return _chart;
    };

This might do it (but there are certainly other ways) - not tested:

_chart.anchor = function(a) {
        if (!arguments.length) return _anchor;
        if (typeof a.anchor === 'function') {
            _anchor = a.anchor();
            _root = a.root();
        } else {
            _anchor = a;
            _root = d3.select(_anchor);
            dc.registerChart(_chart);
        }
        return _chart;
    };

Cheers,
C.

---

Reply to this email directly or view it on GitHub:
#11

[gordonwoodhull]

note this was eventually accepted as #264