Question: Would this work with Stencil? about react-recollect

[davidgilbertson]

The collect function is a React higher order component, so couldn't be used to wrap a Stencil component. (I guess it would maybe work but you'd need both React and Stencil loaded).

Regarding the bug...
What version of react-recollect are you using? I accidentally published a version with no dist directory that was up for about 4 minutes last night :) So if you've got 2.1.1 please update to 2.1.2.

I haven't tested with Rollup, but if you peek into node_modules/react-recollect/dist/index.js can you tell me if you see the export? It takes the form

Object.defineProperty(exports, "store", {
  enumerable: true,
  get: function get() {
    return _store.store;
  }
});

which is just how Babel does exports.

[danawoodman]

I'm using 2.1.2 when this was created.

Here is dist/index.js:

"use strict";

Object.defineProperty(exports, "__esModule", {
  value: true
});
Object.defineProperty(exports, "afterChange", {
  enumerable: true,
  get: function get() {
    return _updating.afterChange;
  }
});
Object.defineProperty(exports, "store", {
  enumerable: true,
  get: function get() {
    return _store.store;
  }
});
Object.defineProperty(exports, "collect", {
  enumerable: true,
  get: function get() {
    return _collect.collect;
  }
});

var _react = _interopRequireDefault(require("react"));

var _logging = require("./logging");

var _updating = require("./updating");

var _store = require("./store");

var _collect = require("./collect");

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

if (!window.Proxy) {
  console.warn('This browser doesn\'t support the Proxy object, which react-recollect needs. See https://caniuse.com/#search=proxy to find out which browsers do support it');
}

window.__RR__ = {
  getStore: _store.getStore,
  getListeners: _updating.getListeners,
  debugOn: _logging.debugOn,
  debugOff: _logging.debugOff
};

Thanks!

[davidgilbertson]

I wonder if this is a Rollup bug? Surely not as I'm building that dist/index.js file with the default Babel settings so the Object.defineProperty(exports, "store", { pattern is used in heaps of libraries.

There's a similar error, also related to stencil.js: typestack/class-transformer#200.

I'll try a minimal build using Rollup.

[danawoodman]

Yeah it's weird. If you setup a brand new Stencil "app" project, install recollect and import it, you should be able to repro it. Thanks for investigating!

[danawoodman]

This relates to #44 right? Should we close this?

[davidgilbertson]

I'd leave this open, but I'm secretly hoping that the output of Webpack-or-Rollup will be something Rollup understands.

…

On Thu, 29 Nov 2018 at 07:08, Dana Woodman ***@***.***> wrote: This relates to #44 <#44> right? Should we close this? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEPNWu1wXyaVNtGZXPdc5Xa7UGnKPl4Pks5uzu1RgaJpZM4Ym4i7> .

[danawoodman]

Ok cool, let me know when you want me to checkout things 👍

[davidgilbertson]

I'm going to close this one now. Rollup no longer has a problem.

But for the question in the issue name, react-recollect isn't going to work with anything but React any time soon. The reason: internally it 'knows' which components are reading which properties from the store by tying in very closely with the lifecycle methods, and updates the store at a very specific point in time so that shouldComponentUpdate and componentDidUpdate get the previous/next versions of the store and allows React to do its PureComponent magic.

Maybe one day I'll go the Redux route of being UI agnostic, but for now I'll leave as is.

Thanks for your input!

[danawoodman]

Makes sense, I figured it wasn't such a simple sort of thing to get working. Maybe I'll look into it someday... maybe...