Pytest is not detecting tests when running inside Docker in CI pipeline about vulnmapai

[davidalami]

Sure, @georgettica , thanks!

[JesseStorms]

Is there a reason why you're specifically testing inside of the Docker container? You can install extra packages on GitHub Runners (docs), so you don't really have to rely on containers. You also can get testing done faster considering you wouldn't have to build it every time.

Also, you forgot to actually add the tests in the Dockerfile, which is probably why pytest isn't working in the container.

[davidalami]

Hi @JesseStorms ,

Thanks for pointing that out! There are a few reasons we chose to test inside of a Docker container:

1. Consistency: Running tests inside a container ensures we have a consistent environment every time. This minimizes the "it works on my machine" type of issues, which can be common with different setups.
2. Reproducibility: By using Docker, anyone can pull the image and reproduce the tests locally. This can be particularly beneficial for new team members coming on board.

That being said, I do see the merit in utilizing GitHub Runners directly for efficiency. We'll evaluate the trade-offs and might consider this for future updates.

And, you're absolutely right. I missed adding the tests in the Dockerfile. I'll make that correction. Thanks for catching that!

[davidalami]

@georgettica , would you like to add copying the tests to Dockerfile and enable testing back in the CI pipeline?

[georgettica]

can I assist?
please assign to me