Registry authentication problem while empty 'auth_token' value is returned by catalog about dxf

[davedoesdev]

@vifrrg thanks for letting me know, I see the issue. I'll integrate the fix.

[davedoesdev]

@vifrrg I don't think we need to check len(rjson['access_token']) if we've already checked rjson['access_token']. What do you think?

[davedoesdev]

I was thinking of:

diff --git a/dxf/__init__.py b/dxf/__init__.py
index 9b48aae..304daa0 100644
--- a/dxf/__init__.py
+++ b/dxf/__init__.py
@@ -305,7 +305,8 @@ class DXFBase(object):
                 r = self._sessions[0].get(auth_url, headers=headers, verify=self._tlsverify)
             _raise_for_status(r)
             rjson = r.json()
-            self.token = rjson['access_token'] if 'access_token' in rjson else rjson['token']
+            # Use 'access_token' value if present and not empty, else 'token' value.
+            self.token = rjson.get('access_token') or rjson['token']
             return self._token
 
         self._headers = headers

[vifrrg]

@davedoesdev

1. As to checking length: it was my bad habbit from one of previous python version where empty string was treated as 'True' in 'if'. So the code like if(""): print("blahblahblah") was printing that "blahblahblah". This behaviour was changed long time ago and I'm still forgetting it every time. :)
   In recent python interpreters it is not really needed. You right.

2. As to Your fix suggestion:
   Yes, it looks more compact and readable then mine. Let me check it in my environment. If it works by the right way - let`s integrate it.
   I'll let You know the result in a few hours.

[vifrrg]

@davedoesdev, Your fix works fine in both cases (old registry without "auth_token" and new one with empty value in it)
May be applied to next release.
Thank You.

[davedoesdev]

@vifrrg released in version 7.5.3
Appreciate the fix!