Coder Social home page Coder Social logo

Comments (7)

datvm avatar datvm commented on August 17, 2024

Hi,

You are right I didn't think about that when making this. Unfortunately I am no longer active in MAUI development for now. Can you make a PR? The code that you need to add should be here:

https://github.com/datvm/LukeMauiFilePicker/blob/6ad55eab9f60827f07e80093c166c2d37621baf4/LukeMauiFilePicker/FilePickerService.MaciOS.cs#L78C30-L78C30

from lukemauifilepicker.

brightertools avatar brightertools commented on August 17, 2024

I have the same issue, the Filename at the top level is set, but FileResult is null so cannot get the path.

I found this as the workaround to the community tools one, but will obviously need the full path to use the actual path?

..saw the PayPal link, but I guess its not supported anymore, so I guess a contribution wont help, I will try look at the code..

from lukemauifilepicker.

brightertools avatar brightertools commented on August 17, 2024

I forked this repo and fixed this for MacOS,

Forked version here: https://github.com/brightertools/MauiFilePicker, with link to a new nuget package..

from lukemauifilepicker.

brightertools avatar brightertools commented on August 17, 2024

I forked the repro, and created my own nuget changing various bits, I have gone back to try and do a pull request, but didn't realise those are done on forks? I cannot create another fork and cannot submit a pull request for a single file, so will need to have time to undo all that.. in the meantime, the fix is just 1 line of code in the file that @datvm mentioned.

from lukemauifilepicker.

datvm avatar datvm commented on August 17, 2024

@brightertools yes you can create a pull request so I can merge it into this repository. You perform it from your own fork/repo (https://github.com/brightertools/MauiFilePicker). Simply go to the PR tab of your fork and click New pull request. The official documentation is here.

EDIT: I see you changed many other files. If you don't mind, I will manually copy the relevant changes into this repo and add a credit in README and code comment but the Github commit will be under my name.

..saw the PayPal link, but I guess its not supported anymore, so I guess a contribution wont help, I will try look at the code..

You are right, I am not actively code MAUI anymore because my job moved to another stack. I can still check and build any fixes contributed by anyone though :)

from lukemauifilepicker.

brightertools avatar brightertools commented on August 17, 2024

@brightertools yes you can create a pull request so I can merge it into this repository. You perform it from your own fork/repo (https://github.com/brightertools/MauiFilePicker). Simply go to the PR tab of your fork and click New pull request. The official documentation is here.

EDIT: I see you changed many other files. If you don't mind, I will manually copy the relevant changes into this repo and add a credit in README and code comment but the Github commit will be under my name.

..saw the PayPal link, but I guess its not supported anymore, so I guess a contribution wont help, I will try look at the code..

You are right, I am not actively code MAUI anymore because my job moved to another stack. I can still check and build any fixes contributed by anyone though :)

Hi,

no problem, glad it helped. 👍

from lukemauifilepicker.

datvm avatar datvm commented on August 17, 2024

This should be fixed in the latest version 1.1

from lukemauifilepicker.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.