Comments (6)
@lucaswerkmeister @addshore what about killing these interfaces? https://github.com/DataValues/DataValues/tree/master/src/interfaces
They where added for some stuff in Wikibase but I would not be surprised (and hope) that they are no longer used.
from datavalues.
One reason is removal of dead code
Another is that these classes are not namespaced and have general names, making them a possible source of future conflicts. At which point we'd need another major release of this library, which might well be more hassle than removing the interfaces.
from datavalues.
Searched for usages in codebase with Wikibase loaded, plus Lexeme, MediaInfo, QualityConstraints etc
- Hashable: implemented by 2 or 3 DataModel classes, not used as type - trivial migration
- Comparable: implemented by many DM classes, not used as type - easy migration
- Immutable: implemented by Snak and Reference, not used as type - trivial migration
My impression is that basically all of this is dead code. Bit surprised by no code using Comparable as type. Maybe I missed something. Would just drop Hashable and Immutable and not create a replacement. Unsure about Comparable.
from datavalues.
Alright, we’ll try to remove the interfaces and see if that works out.
from datavalues.
They’re still implemented in our data model classes as far as I can tell. It would probably be possible to get rid of them with more or less effort, but I don’t really see a reason to, at the moment.
from datavalues.
(Reply to #62 (comment))
What about Comparable?
It seemed from the comment on #58 that there were still doubts about that particular interface, also from a quick code search it didn't seems so clear cut like the other ones (more repos affected).
Presumably you could just have the Comparable interface in Wikibase DataModel if you do not wish to get rid of it. Or if you want to do so slowly.
from datavalues.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datavalues.