Coder Social home page Coder Social logo

Comments (2)

IndexSeek avatar IndexSeek commented on May 30, 2024

Python 3.11 was added to CI with 7ce93b7 and #58. It might be worth exploring the capabilities of tomllib, though.

I'm not sure how to go about implementing the same code differently for different versions of Python. Would it be something like this?

pyproject.toml

[tool.poetry.dependencies]
toml = ">=0.10.2,<0.11"

[tool.poetry.dependencies.tomli]
python = ">=3.7,<3.11"

[tool.poetry.dependencies]
python = "^3.11"

databooks/cli.py

try:
    import tomli
except ImportError:
    import tomlib as tomli

I would think this might work as load seems to be synonymous, but that seems tricky. It seems like tomli is primarily being used to load the config file in cli.py, it might be replaced.

from databooks.

murilo-cunha avatar murilo-cunha commented on May 30, 2024

Thanks for looking into it!

For databooks/cli.py, I believe you are correct!

For the pyproject.toml, I think it should look a bit differently:

[tool.poetry.dependencies]
tomli = { version = "^2.0.1", python = "<3.11" }

Following the docs

from databooks.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.