Coder Social home page Coder Social logo

Comments (5)

airhorns avatar airhorns commented on August 23, 2024 2

@robmoore yep. Thats the intention. It won't however store it or automagically do anything with it, so managing the state and passing the previous state into the next invocation is still the user's responsibility, not target-postgres'.

from target-postgres.

airhorns avatar airhorns commented on August 23, 2024

Is there any guidance on why this target doesn't support actually doing something with STATE messages? Is it that it's hard, or not needed by the original authors? I would have figured everyone needed to store STATEs somewhere, and I feel like the big database all the data is going into is as good a place as any. @AlexanderMann perhaps you could comment -- do you ever want to support storing state messages somehow in this target?

from target-postgres.

AlexanderMann avatar AlexanderMann commented on August 23, 2024

Hey @airhorns, sorry, was on vacation then got swamped with a client!

So some easy questions then the meaty one:

Do you ever want to support storing state messages somehow in this target?

Presently, no. I don't see the benefit to this as I think it muddies the presently single concern of a target of "I get information, I persist it" and instead would make it need to somehow understand state which I think is typically only useful for the tap right?

The meaty question:

any guidance on why this target doesn't support actually doing something with STATE messages? Is it that it's hard, or not needed by the original authors?

DataMill originally crafted a runner for Singer taps and targets to handle state and whatnot. This took state out of the input and did some voodoo on it to persist it remotely as you can imagine wanting to persist STATE messages to something like s3, Postgres, etc. which is different than the target.

This is to say, we didn't need it and felt that ignoring it to start was simpler and got something "pretty-good" working much more quickly.

Conclusion

I think your PR of #130 handles this in a more robust way for all folks if I'm not mistaken? I'd propose that being the conclusion to this issue.

If folks have other suggestions, I'm definitely up for hearing it!

(Also thanks everyone in here for contributing, super helpful)

from target-postgres.

robmoore avatar robmoore commented on August 23, 2024

@airhorns Will the changes in #130 output state for use by the tap on future runs?

from target-postgres.

AlexanderMann avatar AlexanderMann commented on August 23, 2024

Addressed in v0.1.9

from target-postgres.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.