Coder Social home page Coder Social logo

Comments (8)

rochdev avatar rochdev commented on May 20, 2024 1

@eavestn Actually, these are tags that are automatically added by the integration, so there is nothing to do on your part to get them.

It seems the documentation is not clear on what the listed tags are, so I will improve it for the next release.

from dd-trace-js.

rochdev avatar rochdev commented on May 20, 2024 1

@eavestn I think it makes sense. I would probably just change the last part to make it clearer that there are configuration options as well.

Something like:

however, each integration can also be enabled and configured individually.

from dd-trace-js.

eavestn avatar eavestn commented on May 20, 2024

I could look at the code; however, for more enterprise-y integrations, listing this will help people feel more confident in the library, itself, I believe.

from dd-trace-js.

eavestn avatar eavestn commented on May 20, 2024

@rochdev I would remove or modify this statement, then:

Each integration can be configured individually.

That leads the reader to believe this is something over which we have control (at least due to where it appears in the doc.s).

Thank you for the quick response!

from dd-trace-js.

rochdev avatar rochdev commented on May 20, 2024

@eavestn You have control over the configuration options, but not the tags.

Do you think changing the statement to something like this could work?

Each integration has its own options and can be configured individually. There is also a list of tags that get added automatically to the span created by the integration.

from dd-trace-js.

eavestn avatar eavestn commented on May 20, 2024

@rochdev I would suggest something similar:

Each integration has its own list of default tags. These tags get automatically added to the span created by the integration. Every integration is enabled by default; however, which integration is enabled can be individually configured.

Some flavor or combination of the two. Let me know if that above makes sense based on our conversation.

from dd-trace-js.

eavestn avatar eavestn commented on May 20, 2024

Looks good to me!

from dd-trace-js.

rochdev avatar rochdev commented on May 20, 2024

Released in v0.2.1.

from dd-trace-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.