Comments (3)
@jaredx435k2d0 we understand your situation, but can't quote all table/column names by default. This can cause trouble with providers such as Snowflake, in which lower or upper casing must be strictly followed when using quotes.
i.e: you have a table named TEST_123
SELECT * FROM test_123
and SELECT * FROM TEST_123
are the same, while when using quotes you must enforce the correct uppercasing of the table name: SELECT * FROM "TEST_123"
will work, and SELECT * FROM "test_123"
wouldn't
With these details considered, we suggest each user to modify his/her templates at will and, in case you use keywords as table/column names (which we don't recomment), find the "template-way" of covering these cases.
from dbt-coves.
Understood.
I will note here that I'd anticipate this will be an issue for many users. The Fivetran connector for Salesforce, for example, will create a table called group
and order
for all users of that connector. This was the impetus for my request. There are also other instances of this.
That said, I understand your position on it and understand that all Fivetran Salesforce users can handle it on their end.
from dbt-coves.
yeah, I understand your point, but IMO it is a bad practice to use reserved words as table names. dont want
select * from "select" where "where" = 1
lol
Anyway, this seems like an edge case and it is far better to not quote things for the reason Bruno stated above than to force it.
So, there are a few options for a user:
- Manually quote the source table, since you would likely rename the staging table
- Change the dbt-coves template so all tables are quoted
- Quote the specific table with the problem
Let's see what others in the community think.
from dbt-coves.
Related Issues (20)
- Feature request: For automation, add more defaults (and ideally, an `all` option for some) for `generate sources` HOT 3
- Feature Request: Snowflake: Multithreading for performance? HOT 5
- Question: Should `generate sources` remove sources/staging models that are no longer in the database? HOT 2
- [BUG] (question) `generate sources` doesn't pick up new columns HOT 1
- [feat] Setup task expansion to cover lifecycle of dbt-coves vendored components
- Feature: Generate docs.md files with link to schema.yml columns
- Feature: Get source descriptions from OpenAPI specifications
- [BUG] Arrays are casted as string or record HOT 4
- [BUG] Unable to install v1.3 via PyPI/pip HOT 2
- Feature request: `generate sources` "update" mode also update staging models (rather than overwrite or leave unchanged) HOT 2
- Allow custom model naming HOT 1
- [BUG] dbt-coves fails to detect columns in schema HOT 8
- Option to not generate source.yml by default HOT 1
- Support for dbt 1.5 HOT 1
- [BUG][bigquery] --schema not working for underscore on bigquery
- [BUG] Precommit config installed in `['.']` folder
- Support Pydantic v2.0
- [BUG] Add `sqlalchemy` as a dependency HOT 5
- Make the settings path configurable
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dbt-coves.