Coder Social home page Coder Social logo

[BUG]: Linting raises `library-not-found` when importing an unresolvable library within `contextlib.supress(ImportError)` about ucx HOT 4 OPEN

JCZuurmond avatar JCZuurmond commented on June 12, 2024
[BUG]: Linting raises `library-not-found` when importing an unresolvable library within `contextlib.supress(ImportError)`

from ucx.

Comments (4)

ericvergnaud avatar ericvergnaud commented on June 12, 2024

This is confusing. What is the rationale for not raising a library-not-found problem when a library is not found ?

from ucx.

ericvergnaud avatar ericvergnaud commented on June 12, 2024

Oh you mean because of suppress(ImportError) ?
My recommendation would be to provide a mechanism for manually dismissing noisy advices, rather than tackle such complex scenarios

from ucx.

JCZuurmond avatar JCZuurmond commented on June 12, 2024

An alternative to suppressing the message is fine to me. I like the separation of concern of first detecting the library-not-found and then suppressing it in certain cases. I would prefer an automated approach over manual, depending on the frequency it occurs

from ucx.

nfx avatar nfx commented on June 12, 2024

we need to see if the originating import node has try: ... except: ... blocks. or with contextlib.suppress(ImportError) would be fine as well.

from ucx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.