Coder Social home page Coder Social logo

Comments (5)

l3pp4rd avatar l3pp4rd commented on May 21, 2024

yes, might make sense for such an option like AllowRepeatedExpectationMatching. though, then it is ExpectedQuery, the Rows offset should be reset on each match. Would you care to implement it?

from go-sqlmock.

mikemacd avatar mikemacd commented on May 21, 2024

I don't see a way to be able to reset the rows offset in the driver Rows, so it would seem to me that this feature may not be achievable.

from go-sqlmock.

l3pp4rd avatar l3pp4rd commented on May 21, 2024

Since driver.Rows is an interface you can always cast it to type. And we are certain, if it is not nil that it will be rowSets

So the code on this block should be the following:

if expected.rows == nil {
	return nil, fmt.Errorf("Query '%s' with args %+v, must return a database/sql/driver.Rows, but it was not set for expectation %T as %+v", query, args, expected, expected)
}

// reset rows for next use if allowed
if rs, ok := expected.rows.(*rowSets); ok {
	rs.pos = 0
	for _, set := range rs.sets {
		set.pos = 0
	}
}

return expected, nil

Does it make sense?

from go-sqlmock.

mikemacd avatar mikemacd commented on May 21, 2024

I hadn't considered that approach. Thanks! I'll try using it.

from go-sqlmock.

l3pp4rd avatar l3pp4rd commented on May 21, 2024

see another better attempt #148 but after long thought, this may lead to inconsistencies in behavior. cannot accept that

from go-sqlmock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.