Comments (9)
time.sleep(spotify.current_user_playing_track['duration_ms']/1000)
#Instead of checking every second for an ad. We simply get the total length of the song and wait for that ammount of time.
#Now spotify returns miliseconds for song length which is weird but this can easily be fixed with some basic math.
#We get the song duration and divide it by 1000 and we get our time in seconds
I had this code in one of my pull requests so that we dont keep pinging spotify every second. idk if it could help
from spotibyeads.
Umm... To quite an extent, i think the assumption is safe. So, i'm in support.
The question now is, how many minutes?
from spotibyeads.
As for mins ig 3 will be ok as the average length of a song is about that. We can do more as its unlikely that ad will come after 1 song. But shouldn't compromise. What others think?
from spotibyeads.
I think 3 minutes is just okay.
from spotibyeads.
Oh, that's way much better, can you please reference the PR, can't seem to find it.
Also, i think a subtraction of about 5-10 seconds would come in handy.
from spotibyeads.
Oh, that's way much better, can you please reference the PR, can't seem to find it.
Also, i think a subtraction of about 5-10 seconds would come in handy.
It was from PR #8
from spotibyeads.
Oh, i see.
You can open another PR and try to make the change specific i.e addressing just this issue alone.
from spotibyeads.
Done #45
from spotibyeads.
Had to fetch upstream ^^^
from spotibyeads.
Related Issues (20)
- Can't find spotify.exe HOT 4
- Is it possible to bundle the python interpreter installer with main.py in an exe file? HOT 9
- running the program HOT 24
- write credential inside the main folder HOT 3
- Need for a stable and standard update mechanism. HOT 3
- Prebuilt executables HOT 18
- New documentation theme HOT 6
- TypeError : 'method' object is not subscriptable HOT 4
- Might not skip ads when the user manually skips a track or changes playlist. HOT 1
- cannot open localhost8080 in firefox HOT 29
- Queue disappears aftert restart HOT 7
- Encryption of stored client secret. HOT 4
- the script stopped when detected an ad I guess
- Automatic resume of songs after add skipped HOT 10
- Wrong badge link HOT 1
- Can we add web version ? HOT 2
- How about hotkeys? HOT 1
- Not working at all~~~ HOT 1
- doesn't block ads HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spotibyeads.