Comments (31)
I've been subscribed to this issue and using counsel-dash
for months. Specifically, I'm requiring these repos:
And using the commands:
counsel-dash
counsel-dash-at-point
counsel-dash-install-docset
It's awesome and I haven't had any problems at all.
from helm-dash.
Sounds like a plan! I'll go ahead and submit dash-docs
to melpa to get the ball rolling.
from helm-dash.
All right guys, I've verified that both the helm-dash
and counsel-dash
packages function properly post migration. I'm currently following up with counsel-dash
now to remove the dependency on helm-dash.
Thanks for your help, I'm marking this issue as closed :)
from helm-dash.
Wow! That's super nice. First of all, thanks for your initiative and effort there!
I'd say it's a clear yes. @areina wdyt? I'm going to look at the code this week but the idea seems pretty sane
from helm-dash.
Hey @gilbertw1, that's fantastic. I will also take a look at the code, but I like the idea. Let's talk during the next days to see how we can follow the plan that you have described.
Thank you!
from helm-dash.
That's great, thanks for the quick response!
I was thinking about the best way to move forward with the new repo dash-docs
or whatever we decide to call it. I think the cleanest approach would be to create a new repo which is essentially a clone of helm-dash
and I could create a pull request against it with all of my changes specific to the new package. This would likely be the easiest way to do a code review and track the changes.
All the other changes could be independently evaluated in PRs against the two other projects (helm-dash
and counsel-dash
).
I think this division would make all the changes on the whole easier to track and evaluate.
from helm-dash.
What's the status of this? Is there anything I can do to help out?
from helm-dash.
Early when this PR came I tested it and it worked fine, but I guess we should have more testing for it until we can do all the merges.
@gilbertw1 did an amazing job and we totally should get it merged. Let's go for it.
@jbaum98 would you be able to test one of them? helm? counsel?
If anyone happens to read this, it'd be nice if you comment and pick one of the 2 versions to try. Let's see how it goes.
I'll try to use the helm one.
from helm-dash.
Hey guys, sorry I got pretty busy and dropped the ball on following up with this. I've been using the repos as well in my personal configs with no issues so far.
I'll go through and update the Readme documentation of the dash-docs
repo to match the new repo and the changes I made to it.
from helm-dash.
np! I also forgot about this, sorry... Hopefully we're handing it over by our 400stars :).
No rush, really.
Thanks again for your contributions
from helm-dash.
Alright, I've updated the Readme on the dash-docs repo to reflect the fact that it's no longer helm-dash
and provide basic documentation on how to use it as a library.
Additionally, I've fixed up the tests so they all run properly now in dash-docs
and removed the test related files from the helm-dash repo since they would be redundant there.
The next step that makes sense to me is to hand over the dash-docs
repo to you guys, then we can get it submitted to MELPA. Once that is complete, then we can see about testing and merging my helm-dash
specific changes into this repo, so that it will start using the new dash-docs
package underneath.
from helm-dash.
We're fine with giving it to you if you are up to it. Maintenance is low on this project at this stage.
I'd be happy to handle it myself if you're busy, but it makes sense you have the opportunity to step up.
@areina is kinda MIA lately so I guess he's ok with this. :)
from helm-dash.
Sure, I'd be willing to maintain the project and handle the transition.
from helm-dash.
I'm trying it now and it works wonderfully. Will be trying it for the next few days, trying to stress it a bit more.
from helm-dash.
cc'ing some third parties that should probably be aware of this:
@syl20bnr (spacemacs author), we're not there yet, but when we do the change, I guess some changes in spacemacs should be applied (at least in the docs).
@nathankot (counsel-dash author), would you be ok with giving the package name to those new packages?
from helm-dash.
I've merged in the most recent changes into the dash-docs
repository. How's the testing going?
from helm-dash.
Cool!
All good so far. I think we can proceed with the migration.
Is dash-docs published to melpa? I think we can go for that.
Also, we can prepare the PR to melpa to change helm-dash to point to your repo (notifying it should wait there a bit to be merged)
from helm-dash.
dash-docs
has been submitted to melpa!
from helm-dash.
Ok, now we have dash-docs into melpa already.
Next step is taking over helm-dash and counsel-dash, right?
Just a heads up I found some variables and functions that were not correctly exported/imported, @gilbertw1 Could you review this PR gilbertw1#1?
from helm-dash.
@kidd Awesome news!
I just got back from a vacation, I'll review and merge your PR shortly. Next step would be to submit a followup PR to Melpa to point to the new helm-dash repo. After that I'll work with counsel-dash
to get that project updated as well.
Regarding the transition, do you think it'd be better move the repository which would retain all PR's and issues, or just start clean with the fork?
from helm-dash.
I hadn't thought there's the option of transferring the repo. Maybe it's the most sensible thing to do (maybe not a huge win, but some little win is already something),
I'll reach @areina and get this sorted ASAP.
Cheers!
from helm-dash.
Hello,
sorry folks for not being very responsive. I can't transfer the repo to @gilbertw1 because he already has a fork with the same name.
There are two options:
- We create an organization and I move this repo there
- We add the latest changes from
gilbertw1/helm-dash
to this repo, @gilbertw1 removes his fork and after that I transfer the repo.
One question @gilbertw1:
What is your plan?: merging the different "completion frontends" into the dash-docs
repo or keeping helm-
, counsel-
... repositories? The former option could fit better with the idea of creating an organization, we could try to move everything there.
If you plan to merge everything in one single repo, I think creating the org doesn't make sense.
Cheers
from helm-dash.
@areina, I think the best option here would be to create an organization to move the repository to.
I'm planning on keeping each project separate, so that makes the most sense. Additionally, this would prevent the need for any future movement if maintainers change.
I'm currently mobile, but I'll set up an organization shortly. Afterwards we can consolidate the repositories there.
Cheers!
from helm-dash.
Cool, let me know when the organization is created and I will transfer this repo. Thank you for managing this, we really appreciate your effort.
from helm-dash.
No problem! I've benefited a lot from using helm/counsel-dash over the years, so I'm glad I can help evolve the project.
I've created the organization here: https://github.com/dash-docs-el
from helm-dash.
I've just transferred the repo to the org. Would you mind adding @kidd as part of the org?
from helm-dash.
Yep, I sent him a request when I created it.
from helm-dash.
Hey guys, sorry for the delay. I've merged my fork into master and helm-dash is now backed by dash-docs!
I've built and tested the melpa package locally and everything went smoothly. I'll follow up once the update is available via Melpa and verify that as well. Once I've done that, I'll follow up with counel-dash.
from helm-dash.
great news!
Shout if you need some help with testing/anything
from helm-dash.
Nice work to everybody involved.
PR welcome to update Spacemacs if any of you are willing to do it. Thank you!
from helm-dash.
@syl20bnr Sorry for the delay. I've created syl20bnr/spacemacs#12312 to handle any changes needed for spacemacs.
Thanks!
from helm-dash.
Related Issues (20)
- `helm-dash-docset-installed-p` sometimes confuses underscores and version numbers. HOT 1
- helm-dash keeps connecting to remote servers
- Invalidly quoted urls in docset HOT 4
- Cannot retrieve list of official docsets HOT 19
- Error when install docset `M-x helm-dash-install-docset` HOT 1
- How to narrow down to one specific docset? HOT 1
- Java docsets on linux are encrypted HOT 1
- helm-dash-installed-docsets is gone HOT 1
- Install [official/user] docset contacting error HOT 7
- Strange error "too long" when installing docsets HOT 1
- setq-local dash-docs-docsets does not work HOT 1
- Narrowing down to one specific docset does not work? HOT 5
- dash-docs-docsets does not exist: how to set mode specific docsets? HOT 2
- gnutls.el error while trying to install a docset HOT 3
- Bad comment header in dash-docs.el. HOT 1
- Wrong type argument: stringp
- Opens wrong url/Installs docset in wrong location ? (macos) HOT 1
- When using helm from terminal emacs, typing too quickly may result in helm unexpectedly closing
- (Read before posting) Project unmaintained? HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm-dash.