Comments (5)
The other option is to treat a parameter of test1
as having no value, and test2=
as having an empty value.
Then a URL of something?test1&test2=&test3=abc
would encode the difference and parsing back in could recreate it. (If there was no way to represent the difference in text, it can't be round-tripped, but this may be a way.)
I'll have to check what the WhatWG URL spec does, because I still hope to one day migrate Dart Uri
to that behavior.
If they don't distinguish the two cases, then Dart also won't.
If they do, then we may want to see if this is a breaking change worth making early, or is better to include it on a bigger update.
(Probably the latter, since we never noticed before.)
from sdk.
Labels: area-core-library
, type-bug
Summary: The Uri
class encodes empty and null query parameters identically, making it impossible to distinguish between them after parsing. This inconsistency with common conventions, like those used by Java Spring, can lead to unexpected behavior when interacting with other systems.
from sdk.
I think this is working as intended.
URIs are textual, they cannot represent "key with no value". Well, they could, but they don't.
As your example http://google.com?test2&test3=&test4=null
shows, that URI has the keys test2
, test3
and test4
.
Their values are the strings ""
, ""
and "null"
.
There is no support in a Uri
for having a key with no string value, so if the key is there, the value is at least the empty string.
from sdk.
That said, while this is intentional, it doesn't mean we can't change it. (It's harder, because it may break existing code).
So labeleing as enhancement request.
from sdk.
Thanks for your reply, Lasse. Your explanation made me realize an error in my reasoning (of course the String "null"
cannot always be taken to mean null
), but the main point is still valid:
To me it would seem reasonable if the following test passed, which currently it does not do.
import 'package:flutter_test/flutter_test.dart';
void main() {
test(
"URI encoding should not change value assigned to a parameter",
() {
final queryParameters = {"test": null};
final uri = Uri(queryParameters: queryParameters);
final uriString = uri.toString();
final parsedUri = Uri.parse(uriString);
final parsedParameters = parsedUri.queryParameters;
expect(queryParameters["test"], parsedParameters["test"]);
},
);
}
This could be reached by removing all key-value-pairs with a null
value when creating the query string. But yes, this might break existing code.
If you're happy to say the current behaviour is as intended, we can close this.
from sdk.
Related Issues (20)
- [Wildcard Variables][analyzer] Const wildcard initializer list variables should not accessed. HOT 1
- unintended_html_in_doc_comment triggers on some variants of allowed html tags in package:web HOT 1
- js_interop changes in 3.6 (master) to JSTypedArray subtypes break passing SharedArrayBuffer as the underlying buffer. HOT 3
- Dart analyzer fails to analyze condition in a list construction in enhanced enum constructor HOT 2
- [CP] Fix crashes due to unhandled StructuralParameterTypes in UP in the CFE HOT 1
- Macro with Map param doesn't work properly HOT 1
- [native assets] Add dynamic linking integration test for `dart` HOT 1
- Analyzer doesn't notice incorrect return type of generic method HOT 5
- [dart2wasm][ffi] Error: Argument to 'Native.addressOf' must be annotated with @Native. HOT 3
- [cfe/ffi] Cascading error on wrong types when using `.address` HOT 1
- Call dart function from a dynamic lib HOT 3
- [CP] Fix analysis_options.yaml "include:" for nested folders in workspace. HOT 1
- False positive in unintended_html_in_doc_comment lint HOT 2
- [breaking change] Compute closures of type schemas in the upper bound computations in the CFE as specified HOT 2
- Assists for adding and maybe removing digit separators from number literals
- [breaking change] Mark `IOOverrides` as `base` HOT 3
- Check if current is available within Iterator without moving the iterator HOT 1
- A directory which is "excluded" via analysis options should not be searched for other analysis options. HOT 1
- Missing unnecessary `!` warning with nested extension types HOT 4
- Exception from yaml parsing during dart fix HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk.