Comments (2)
I think it makes more sense to point to the start of the string literal. @jensjoha do you see a problem in making such a change?
from sdk.
A StringConcatenation
is created via createStringConcatenation
which is called twice:
push(forest.createStringConcatenation(offsetForToken(endToken), expressions));
push(forest.createStringConcatenation(offsetForToken(startToken), expressions ?? parts));
So it's only somtimes it's the end token. Generally I think we just give it what we have available, but yeah, making it the start instead would make more sense.
I'll add it to my todo list.
from sdk.
Related Issues (20)
- [vm/ffi] Add `dladdr` embedder callback
- Analyzer Feedback from IntelliJ
- bug: FutureOr<FutureOr<Object>> does not resolve to FutureOr<Object> HOT 1
- Analyzer allows `super` as expression in several places HOT 4
- future doesn't throw correctly inside try block HOT 1
- [vm/ffi] Support `.address.cast()` in leaf calls
- File APIs inconsistently handle paths ending in `.` on windows in 3.4.3 HOT 8
- [infra] `tools/patches/flutter-engine/apply.sh` incompatible with Python 3.12
- New coverage_closure_call_after_optimization_test is timing out on AOT
- Compiler crash HOT 1
- Document machine/rules.json HOT 8
- Issues with Socket and SecureSocket error handling and documentation HOT 2
- [CP] [dart2wasm] Make `dart compile wasm` compiled apps disable `dart.library.ffi` HOT 5
- Quick fix: convert `UNUSED_CATCH_CLAUSE` to wildcard
- [CP] Pub: Properly handle case where the client is unable to fetch advisories HOT 4
- Analyzer Feedback from IntelliJ
- [cfe/macros]: empty metadata iterable at compile time
- dart.exe take %97 of memory make pc laggy HOT 3
- New error message for `depend_on_referenced_packages` quick-fix HOT 1
- Adding an extension type with a typedef representation type makes `pkg/kernel/test/dart_scope_calculator_test` throw during serialization
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk.