Comments (5)
since we're checking it based on the name.
Yeah, there's the issue.
Can you even do:
const myResource = ResourceIdentifier(...);
@myResource
Some declaration...
?
from sdk.
Yes, the current check is name and library only. I like the idea of subclassing!
from sdk.
I think we should likely disallow implementing, because the metadata
field could not exist in a subclass.
Also, we should specify what happens to subclasses specifying more fields. Are they reported in the resources.json
? If they are reported, we should come up with an encoding that does not lead to potential conflicts.
class JClassIdentifier extends ResourceIdentifier {
final String name;
const JClassIdentifier(this.name)
: super('jnigen');
}
This would currently lead to a class between name
in the annotation and name
of the method the annotation is on in how it's currently encoded.
@mosuem @HosseinYousefi @lrhn Any preferences on if the metadata
field is special and the only one reported, or if we report all fields?
from sdk.
@lrhn
Unrelated question: why can we create a const string but not a const map from const constructor's arguments?
class JClassIdentifier extends ResourceIdentifier {
const JClassIdentifier(String name, String somethingElse)
: super(const {name: somethingElse}); // Error!
}
I assume it's because the const string and string have the same syntax but const map requires an extra const
keyword. It would be nice to have something like "preferConst
" so we could do
class JClassIdentifier extends ResourceIdentifier {
const JClassIdentifier(String name, String somethingElse)
: super(preferConst {name: somethingElse});
}
Since making {name: somethingElse}
to be "preferConst
" by default is a breaking change.
from sdk.
Any preferences on if the
metadata
field is special and the only one reported, or if we report all fields?
Since we can't quite fill the metadata as a map using the arguments of the subclass' const constructor, I prefer it if we report all fields if possible.
from sdk.
Related Issues (20)
- `ConstructorDefinitionBuilder.augment` cannot augment factory constructor
- [vm] Dart AOT runtime should refuse to run snapshots with incompatible sanitizers HOT 2
- [vm] gen_snapshot without santizers should be able to create AOT snapshots to be used with AOT runtimes with sanitizers HOT 1
- [CRASH] `dart run` fails logging `Compilation did not produce any result...` and crashes with `PathNotFoundException` HOT 5
- allow to destructure record types with positional fields HOT 8
- [analyzer] add warning when abstract interface class has unused implementation.
- [analyzer] incorrectly marking as dead code when accessing record property in ternary HOT 3
- Breakpoints skipped in tests when injecting late initialized dependency. HOT 3
- Function argument rejected based on faulty inferred parameter type
- AOT compilation runs into speculative input use by `CalculateElementAddressInstr` HOT 1
- Analyzer Feedback from IntelliJ
- Type inference for abstract classes with recurring generics can't be inferred HOT 10
- The front end is not happy about wrong constructor declaration
- The front end is not happy about wrong extension type constructor declaration
- pkg/analyzer/test/src/dart/resolution/augmented_invocation_test fails with RuntimeError on analyzer-asserts-win bot HOT 2
- Code completion suggestions are irrelevant / context unaware HOT 2
- [Wildcard Variables] Language Tests in `tests/language` HOT 5
- [Wildcard Variables] All tests in `tests/language` and co19 passing.
- [Wildcard Variables] Experiment Flag HOT 3
- [Wildcard Variables] CFE Implementation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk.