Comments (3)
Good catch, @munificent! And yes, @johnniwinther, your analysis is correct. I dug through the code, and the problem occurs whenever the following are all true of a list pattern:
- The matched value type is
List<U>?
for someU
. - The element type of the list pattern is
V
, whereU <: V
(meaning the only way that the type check implied by the list pattern can fail is if the matched value isnull
). - The list pattern doesn't match all possible list lengths.
When this happens, flow analysis incorrectly uses the ifFalse
control flow branch of the type test as the "unmatched" control flow path for the pattern. In other words, it fails to account for the possibility that the list pattern might fail to match due to the list having an incorrect length. As a result, it promotes the matched value type to Never?
(which is equivalent to Null
) in the "unmatched" control flow path.
I'll work on a fix ASAP.
from sdk.
Fix is out for review: https://dart-review.googlesource.com/c/sdk/+/364942
from sdk.
@stereotype441 I think the problem is in the flow analysis. It seems like maybeList
is promoted to Never?
via the "unmatched" path through [var element]
.
from sdk.
Related Issues (20)
- Intersection type soundness issue HOT 1
- language/nnbd/late/covariant_instance_field_test fails with inlining disabled HOT 4
- `Uint8List.fromList([...])` is ~10x slower than `Uint8List(length)..[0] = #..[1] = #` HOT 2
- [native_assets] Spaces in paths HOT 2
- Unreliable network connection timeout parameters HOT 4
- A simple code that break dart fix HOT 3
- Code completion doesn't suggest enum values when imported aliased HOT 1
- Allow DTD clients to know when a service/method is available/unavailable HOT 6
- [ffi] Varargs should give an error on uint8, int8, uint16, int16 and float HOT 2
- Failures on Expose CommentToken as analyzer public API...[analyzer] Prioritize errors in analysis_options/pubspec errors when running "dart analyze" HOT 1
- ffi/callback_unwind_error_test was flaky, turned Crash on vm-aot-linux-release-arm-qemu
- Failures on Expose CommentToken as analyzer public API...[analyzer] HOT 3
- [dart2js] dart2js should do better inlining of `@Native` method stubs
- Docs on how to access and use the test status database HOT 4
- Isolate-local native callables create spurious exception in debugger when returning null HOT 3
- [breaking change] Change the context for the operand of `throw` to `Object`. HOT 1
- Create a method to know if a type is a Built-in type HOT 11
- Contradictory behavior from `body_might_complete_normally` HOT 4
- toStringAsFixed and Number format does not work correctly HOT 2
- [dart:js_interop] Add JSArray.from static method. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk.