Coder Social home page Coder Social logo

Comments (6)

jacob314 avatar jacob314 commented on August 22, 2024

LGTM

from sdk.

sortie avatar sortie commented on August 22, 2024

Can you please add more detail to your answers? I'm not one of the people that approve cherry-pick requests, but there is almost no context here. I designed the current form of the cherry-pick process and our style is to write the cherry-pick request so people without context can understand what the issue was, what the fix is, and why it is safe. You should think of this issue as the entry point for people that want an overview of what happened and why. @itsjustkevin

Issue Description
#55475

Please summarize the issue. The reason we have this separate issue is because the original issues are usually an investigation and it's much more work to read the fully issue and locate the conclusions :)

What is the fix
Upgraded version of vm_service in DevTools to 14.2.1

What changed in the vm_service code to fix the problem?

Why cherry-pick
DevTools sometimes fails to snapshot memory with vm_service to 14.2.0

OK that sounds bad.

@kenzieschmoll raises doubts #55475 (comment) that the cherry-pick might not be needed after all? Can you confirm whether a cherry-pick is needed?

No visible risk

Can you please elaborate in more detail about why this cherry-pick is safe? Changes always have the potential for new bugs. If a mistake was made, it could result in a broken 3.4.0 release when the beta period is over, so we usually want to know the change is safe. E.g. is there any tests that catch this problem and confirm it no longer exists? For instance, did vm_service 14.2.1 get tested with devtools?

from sdk.

polina-c avatar polina-c commented on August 22, 2024

Thank you!
Fixed description and replied #55475 (comment)

from sdk.

sortie avatar sortie commented on August 22, 2024

#55475 (comment) points out the devtools CP build somehow still contains vm_service 14.2.0 and a new CP build would be required.

from sdk.

polina-c avatar polina-c commented on August 22, 2024

#55475 (comment) points out the devtools CP build somehow still contains vm_service 14.2.0 and a new CP build would be required.

Nope, it does not. That comment was made before I created CP to point out to the problem of the existing version of DevTools for beta, explaining why we need CP. There are two CPs in this issue: one for Dart SDK and one for DevTools.

from sdk.

vsmenon avatar vsmenon commented on August 22, 2024

lgtm

from sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.