Comments (3)
/cc @aam
from sdk.
This is likely related to https://dart-review.googlesource.com/c/sdk/+/269746/comment/f003dd67_7e1c8a4b/
This comment talks about different ParallelMove
(BlockEntryInstr::parallel_move_
). The one generated here is a normal one after the block entry.
My guess is that the actual bug is here:
void FlowGraphAllocator::AssignSafepoints(Definition* defn, LiveRange* range) {
for (intptr_t i = safepoints_.length() - 1; i >= 0; i--) {
Instruction* safepoint_instr = safepoints_[i];
if (safepoint_instr == defn) {
// The value is not live until after the definition is fully executed,
// don't assign the safepoint inside the definition itself to
// definition's liverange.
continue;
}
This check will not correctly work for Parameter
"hidden" inside CatchBlockEntry
. I wonder why this is not just doing range->Start() < pos
maybe it is concerned about presplit liferanges that don't start at their definitions?
from sdk.
@a-siva I have a fix for this almost ready (https://dart-review.googlesource.com/c/sdk/+/363423).
from sdk.
Related Issues (20)
- [dart2wasm] Attempt to execute code removed by Dart AOT compiler (TFA) HOT 13
- Analyzer Feedback from IntelliJ
- :memo: Requests for Dart refactorings
- [vm][cfe][frontend_server] Make "native_assets.yaml" reusable
- Option to disable implicit type checks without minification when compiling to JS HOT 1
- Verify that TFA inferred types are as specific as Dart types
- New TargetTypes for `@doNotStore`?
- [dartdev] Fails to report VM service URL on Windows when run from different drive HOT 7
- dart fix crash in [email protected]+0x14e HOT 2
- ☂️ [vm/ffi] Multi language debugging
- [resource_identifiers] Record constructors
- [resource_identifier] Extension types
- [breaking change] Add `Random.fillBytes` method. HOT 6
- [CP] Fix WASM error caused by incorrect return type HOT 6
- Do data classes require code gen? HOT 4
- dart2wasm fails inside sync* functions with a switch statement HOT 6
- Analyzer Feedback from IntelliJ
- Analyzer Feedback from IntelliJ
- Analyzer quick-fix: Add import with `show`.
- File operations hang forever after opening unrelated named pipe HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk.