Coder Social home page Coder Social logo

Comments (7)

sigmundch avatar sigmundch commented on July 18, 2024 3

I support this CP too, for both stable and beta. I expect we'll see more usage on dart2wasm after 3.4, so I'd especially want to include it in 3.4 beta before it goes out as stable.

@srujzs - consider updating the description above to clarify which kind of JS interop member/methods are affected. I believe it's only top-level methods and possibly static class methods and properties?

cc @mkustermann

from sdk.

srujzs avatar srujzs commented on July 18, 2024 1

Done!

from sdk.

kevmoo avatar kevmoo commented on July 18, 2024

LGTM! Minimal risk, but clearly fixing an issue with Firebase!

from sdk.

kevmoo avatar kevmoo commented on July 18, 2024

Need to make sure this is merged into BETA, although getting it into the current stable is also nice

from sdk.

itsjustkevin avatar itsjustkevin commented on July 18, 2024

Please open a beta CL also, we are currently prioritizing beta cherry-picks as we stabilize before the next quarterly release.

from sdk.

itsjustkevin avatar itsjustkevin commented on July 18, 2024

CC: @sigmundch

from sdk.

srujzs avatar srujzs commented on July 18, 2024

consider updating the description above to clarify which kind of JS interop member/methods are affected. I believe it's only top-level methods and possibly static class methods and properties?

Updated. It affects any JS interop member that uses the enclosing library's JS annotation and could contain optional parameters - top-level methods, constructors, and static methods.

from sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.