Mockito without mirrors? about mockito

[matanlurey]

It looks like the only invocation of true mirrors is spy:

dynamic spy(dynamic mock, dynamic spiedObject) {
  var mirror = reflect(spiedObject);
  mock._defaultResponse = () => new CannedResponse(
      null, (Invocation realInvocation) => mirror.delegate(realInvocation));
  return mock;
}

I imagine this could be moved to mockito/spy.dart.

The rest of mirrors uses noSuchMethod, which is a sort of mirrors-light. Is that still supported in Flutter/AOT? We've had a few conversations about code-gen based mockito that had mixed reviews.

[matanlurey]

It looks like noSuchMethod works for AOT. @TedSander is this a reasonable change?

[TedSander]

Yep seems reasonable. Anyone want to send a pull request? I imagine we shouldn't have a breaking change for this. So have the original entrypoint export spy.dart, and mock.dart (or something like that,) and have AOT just import the second one.

[matanlurey]

@Hixie does that sound OK?

We'd have:

lib/
  src/
    mock.dart
    spy.dart
  mockito.dart: Original library that also exports spy (won't work in AOT)
  mockito_no_mirrors.dart: Mockito without the spy function (or whatever else is added)

[Hixie]

sgtm

[Hixie]

and thanks for looking at this so quickly! much appreciated.

[matanlurey]

@TedSander I'll shoot you a PR shortly 💋

[matanlurey]

@Hixie of course!

[matanlurey]

Alright, take a look at PR https://github.com/fibulwinter/dart-mockito/pull/28

[Hixie]

Thanks!