Add git so that dart pub get works for pubspecs with git dependencies about dart-docker

[cpswan]

@subfuzion - Looking deeper into the pubspec.yaml that brought me here, the problem isn't with dependencies on pub.dev but only happens with git references.

So these are fine:

dependencies:
  args: ^1.5.0
  uuid: ^3.0.4
  convert: ^2.1.1
  crypto: ^3.0.0
  crypton: ^2.0.1
  collection: ^1.14.13
  basic_utils: ^3.0.0

But this causes the issue:

  at_persistence_secondary_server:
    git:
      url: https://github.com/atsign-foundation/at_server.git
      path: at_secondary/at_persistence_secondary_server
      ref: trunk
      version: ^1.0.1+7

So the blast radius for this being a problem is diminished, but still likely to be meaningful.

[subfuzion]

Adding git to the base image definitely makes sense for handling git dependencies; adding it is certainly a better experience than asking the community to create their own images to address this use case.

[athomas]

FYI, this will get published to docker hub with the upcoming 2.13.3 release later this week.

[subfuzion]

@cpswan I'm unable to replicate this. I can enter a dart container (docker run -it --rm -v $PWD:/app -w /app --entrypoint bash dart) from a directory with a project and run dart pub get. Also, all the Dart Functions Framework examples use dart:stable as the base image and these all continue to work (and pass our CI tests).

Could you provide more detail about what's happening for you (perhaps with a link to a gist or repo)? Context and details about how the issue manifests itself are generally more helpful than suggestions how to fix (although we do also appreciate suggestions and PRs): architecture, operating system, Docker version, sample, are all very useful. Thanks!

[derrick56007]

experiencing the same issue when using a git dependency

[Dokotela]

I have a follow-up question to this. I have a git dependency in my dart app, but it's to a private repo. I've been trying to put credentials in my Docker file, but haven't been successful. Has anyone been able to do this?