Comments (6)
Still seeing these: #43
from browser_launcher.
@annagrin - can you take a look?
from browser_launcher.
cc @elliette as well
from browser_launcher.
Thanks! Will take a look
from browser_launcher.
I see what's happening, not sure the best way to fix the test.
We are opening chrome://version/
, but prefixing it with /json/new?
(see: https://github.com/dart-lang/browser_launcher/blob/master/test/chrome_test.dart#L195), so really we are trying to open /json/new?chrome://version/
. This never opens and we get back the response code 405: Method not allowed error.
I'm not sure why we are pre-fixing chrome://version with /json/new?
. @annagrin, I see you added that in #29, do you mind looking?
One final note is if we remove /json/new?
and just try to open chrome://version/
, this fails with the following error: https://github.com/dart-lang/sdk/blob/73dea244cc94dc7dbc00a751b2c3151797f4b836/sdk/lib/_http/http_impl.dart#L2755) It looks like the Dart HTTP client only accepts http
and https
scheme (not chrome
scheme).
from browser_launcher.
It seems that something changed in chrome, and now /json/new
is not allowed with chrome:
uris. It used to work, and still does for non-chrome uris... I unfortunately don't know another way to navigate to a chrome://version
page (or any other) from chrome!.chromeConnection.
@elliette @devoncarew if you know a way I'd love to learn! If not, we can just disable these tests for now, like I already did in webdev.
from browser_launcher.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from browser_launcher.