Comments (5)
Blocked on google/protobuf.dart#107
from bazel_worker.
This now blocks rolling protobuf 0.9.0 into the Dart SDK.
Any way this can be solved without a change on the protobuf end?
from bazel_worker.
Note that this will also block rolling protobuf internally. There isn't any simple solution I am aware of on the bazel_worker end of things to unblock this, nothing that compares at least in simplicity to restoring the public method in protobuf (it still exists, it's just private).
from bazel_worker.
Actually - I take that back it looks like we might be able to use GeneratedMessage.writeToCodedBufferWriter
, I will give that a try.
Ok, I remember now why that isn't a good solution. Since we need to lead with the size of the buffer we would end up having to serialize the buffer to bytes twice to do that, instead of just once with the existing approach.
Lied again! We should actually be able to do this efficiently still without to much extra code, by creating a new Uint8List out of the original buffer for the message and a new one that only contains the size delimiter. Or, at least I can see if that works as expected.
from bazel_worker.
Wohoo. Thanks!
from bazel_worker.
Related Issues (11)
- Upgrade from comment-based generics syntax
- Fix "dynamic as bottom" warnings HOT 1
- Get all the tests passing with --preview-dart-2 HOT 1
- Allow usage of protobuf 0.10 HOT 1
- worker_protocol.pb.dart is out of date HOT 3
- Update to support pkg:protobuf v0.12.0 HOT 1
- Pass in environment variables to CFE HOT 1
- Upgrade to latest protobuf HOT 3
- BazelWorkerDriver will stall forever on requests if spawnWorker has an error HOT 5
- Bazel worker needs to be compatible with async 2.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bazel_worker.