Coder Social home page Coder Social logo

Comments (5)

jakemac53 avatar jakemac53 commented on June 9, 2024

Blocked on google/protobuf.dart#107

from bazel_worker.

lrhn avatar lrhn commented on June 9, 2024

This now blocks rolling protobuf 0.9.0 into the Dart SDK.

Any way this can be solved without a change on the protobuf end?

from bazel_worker.

jakemac53 avatar jakemac53 commented on June 9, 2024

Note that this will also block rolling protobuf internally. There isn't any simple solution I am aware of on the bazel_worker end of things to unblock this, nothing that compares at least in simplicity to restoring the public method in protobuf (it still exists, it's just private).

from bazel_worker.

jakemac53 avatar jakemac53 commented on June 9, 2024

Actually - I take that back it looks like we might be able to use GeneratedMessage.writeToCodedBufferWriter, I will give that a try.

Ok, I remember now why that isn't a good solution. Since we need to lead with the size of the buffer we would end up having to serialize the buffer to bytes twice to do that, instead of just once with the existing approach.

Lied again! We should actually be able to do this efficiently still without to much extra code, by creating a new Uint8List out of the original buffer for the message and a new one that only contains the size delimiter. Or, at least I can see if that works as expected.

from bazel_worker.

lrhn avatar lrhn commented on June 9, 2024

Wohoo. Thanks!

from bazel_worker.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.