Coder Social home page Coder Social logo

Comments (6)

mandarvaze avatar mandarvaze commented on May 26, 2024

@darrenburns

I'm thinking we add a print/log statement here ? We use path computed earlier in the function in the print/log statement.

Additionally, in two places before return {} we can print/log something like "Using default config"

Let me know if this makes sense - I'll make a PR

from ward.

darrenburns avatar darrenburns commented on May 26, 2024

I think here would make most sense:

. I'm trying to keep the output limited to that file rather than scattering it all over the place.

In the case where we're using the default config, i.e. not pyproject config, I'd prefer if we just don't print anything.

from ward.

mandarvaze avatar mandarvaze commented on May 26, 2024

Thanks.

Yours is definitely cleaner approach ;)
I'll study the code a little to figure out how to get pyproject path in the code you mentioned above.

from ward.

darrenburns avatar darrenburns commented on May 26, 2024

Cool - it'll probably involve looking at the docs for Click and seeing if it's possible to pass the data returned from the callback into the wrapped function. Let me know if you have any questions or need help with anything 😄

from ward.

mandarvaze avatar mandarvaze commented on May 26, 2024

I have a working solution ready, but it seems a lot of work to pass one string (toml path) to the ultimate "print" destination.
May be I am doing something wrong.
I'll submit a PR after following contributing guidelines.

from ward.

darrenburns avatar darrenburns commented on May 26, 2024

Added in 0.40.0b0

from ward.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.