Comments (22)
+1 to time based rules around on / off. I would prefer simple scheduler rather than sun following.
from darkreader.
+1. There is already the time setting, but getting the exact timing for the sunset without needing to change time setting every few month would be better.
from darkreader.
from darkreader.
@c-borgia I totally agree, but I can see why one would want this.
@alexanderby , you could use https://github.com/mourner/suncalc to accomplish this.
To get the address as longitude and latitude you could use this code https://gist.github.com/BastinRobin/7463602.
Then you just need to provide a field to enter the address (maybe with autocomplete provided my Google Maps) and a checkbox to enable the feature.
from darkreader.
I do like white pages during the day and the dark at night. I find myself switching it all the time so I do see this being a good idea. To save time on that switching I end up doing anyways.
However, maybe a simple scheduler would be a better idea rather than zip code. Less personal information needed.
My problem with Flux and sunrise. What if for example I like to wake up before the sunrise? I want the white to energize and signal wakefulness. To the basics white seems to be more energizing as it contains more blue on screens than black does.
I believe a simple scheduler based on computer time might be better. A default time could be in place as long as I can modify it.
Maybe having both would be best. My general thoughts.
from darkreader.
I must π this suggestion. It should definitely be an optional feature, but I would absolutely use it. As it is, I manually toggle the app--when I remember to. But some days I spend a few hours wondering why Facebook looks weird, and some nights I am blinded by a flash of un-inverted web page. π
from darkreader.
Isn't it better and easier to just toggle on time? Maybe with an extra feature afterwards to toggle relatively on the sunset/rise time?
from darkreader.
This is very useful. I use https://atom.io/packages/sunset in atom and https://marketplace.visualstudio.com/items?itemName=gharveymn.nightswitch for this. I guess it should be easy to borrow some code to implement this.
from darkreader.
+1 to time based rules. I think this could be implemented in a first step. Later on, a sun following scheduler may follow.
You can switch your Firefox profile with the Add-On "automaticDark - Time-Based Theme Changer" being available on GitHub: https://github.com/skhzhang/time-based-themes/
Maybe the code base can be reused.
from darkreader.
+1. I might look into implementing this and doing a PR when I have a bit more free time.
from darkreader.
+1 on this
from darkreader.
The thread says that the feature was added in December but how do I activate it?
from darkreader.
@ars4l4n It was added to the features backlog but it's currently not implemented. However, you can currently set a fixed time to enable/disable dark reader. See: #1312 (comment)
from darkreader.
NightOwl and Flux are increasingly popular apps that allow, for example, MacOS system themes to change with sunrise/sunset. This is the best dark-content extension for firefox, so it would be really awesome to see this implemented here, too. Sunrise and sunset times change every day, so in order to sync up with other apps, you have to keep changing this setting which is a pain.
from darkreader.
That menu icon is a bit small and I have never noticed it despite being quite technically adept. :(
Is it possible to detect the status of the browser theme? I use Flux to automatically switch to dark mode on macOS at sunset and this feature is coming natively in the system in Catalina; static time changes for the modes areβwellβ¦ static.
from darkreader.
At least on macOS 10.15, the system now includes an Auto setting for the dark/light theme. Along with Dark Reader's Auto setting (which is present in its Safari version!) this provides pretty much what the OP wants.
I realise this may not apply to the extensions for other browsers and other OSes.
from darkreader.
@Yoshi2889
I'm about to switch anyway
windows has no vision, no taste, no love for detail
from darkreader.
At least on macOS 10.15, the system now includes an Auto setting for the dark/light theme. Along with Dark Reader's Auto setting (which is present in its Safari version!) this provides pretty much what the OP wants.
I realise this may not apply to the extensions for other browsers and other OSes.
I am not sure if this is a known bug or not, but for me (macOS Catalina beta) Dark Reader does not pick up on the current status of the auto dark/light theme. Regardless of whether Catalina's auto theme is using the light or dark theme, Dark Reader always shows pages in light mode when set to auto. Only if Catalina is explicitly set to (permanent) dark mode does Dark Reader's auto mode change web pages to dark.
from darkreader.
Thanks to @Kimbatt, who implemented this feature. It will be released soon after I review other Pull Requests and test a little bit. You will have to specify your location, so that Dark Reader don't have to ask for location permissions.
@rben01 Thanks for the details, I was not aware of Auto setting in Catalina.
from darkreader.
@alexalekseyenko yeah, same issue here. (Love the app, though!)
from darkreader.
Same request here...
from darkreader.
This is not working in Firefox for Mobile. Probably needs to be implemented: the dark reader is nice when you use it at night, but during the day it just changes the visuals of all the websites and that's not the thing I want to have during normal browsing, not the night one. Thanks!
from darkreader.
Related Issues (20)
- [Broken Website] hsbc.ca is blank HOT 3
- [Broken Website] 1.next.westlaw.com HOT 3
- [Broken Website] Bright background not adjusted in various Asciidoctor Docs content blocks HOT 4
- [Broken Website] themarker.com gets a strange green background
- [Broken Website] wikipedia.org
- [Broken Website] IMDB.com HOT 11
- [Broken Website] Bad influence on the QR code HOT 1
- System color update not attended to while/after application inactivity HOT 1
- [Broken Website] Google docs page reversed
- [Broken Website] https://webchat.kde.org/
- [Feature Request] "Theme for all websites" should be "Theme for current site" by default
- [Broken Website] Some text (lower portions, reviews) on Meijer websites does not invert correctly HOT 2
- [Bug] Dark reader keeps enabling/disabling itself
- Dark Reader Chrome ruins scroll bar
- [Broken Website] Dark theme not detected automatically (https://wagtail.org/)
- [Broken Website] important graphics on website (supercoach.heraldsun.com.au/afl/) not rendered correctly HOT 1
- [Bug] Static doesn't make everything white to black, but dynamic inverts images. Can we get both?
- [Broken Website] App Store Connect modals not dark
- [Broken Website] MXToolBox.com
- [Bug] Installing 4.9.78 on Firefox: "This add-on could not be installed because it has not been verified." HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from darkreader.