Comments (4)
Thanks for testing.
I'll fix 1.
2. I choose '/'
because that is separator for many wysiwyg editors like ckeditor. I vote for '-'
then :)
3. If somebody uses 'url': 'app.model'
i don't think it can be by accident, so it means model must be there. I don't like idea of mixing model
key also in app level, it is too confusing. This parameter sets nothing but url
so i think url
key is the right for it.
4. It is quite specific, but i guess it could be useful for others too, for example when linking separate applications/admins together. What do you think, should i add blank=True
or more universal target=_blank
, i doubt if somebody uses iframes and could need different target than _blank...
from django-suit.
3.: The thing is that you end up having wrong URLs if you have a typo (--> model doesn't exist). On the other hands, it's pretty easy to check for typos in links by just testing them :)
4.: Yeah don't do the target=...
thing. I don't think we have to support anything that has anything to do with frames ;)
from django-suit.
Could you please test latest version?
from django-suit.
Awesome! Works perfectly.
from django-suit.
Related Issues (20)
- Sidebar is not properly showing HOT 3
- Almost a year without any new merges? HOT 3
- Chosen list in filtered manytomany field is too small to see any chosen selections
- Error 500 on demo HOT 1
- Missing arrow on select with suitv2
- Django Suit v2 Date Inline not showing calendar
- Unable to test an admin action with suit installed HOT 1
- when use npm run build,get a error
- Django Admin Hide Superuser User HOT 1
- Template Issue Filter position v2 HOT 4
- v2 suit tabs not working HOT 1
- Any V1 forks that support Django 3x? HOT 16
- RTL support
- V2 forks on bootstrap5 : need help HOT 2
- add subitems for the suit menu subitems(3 level tree)
- Row styling failing silently?
- object-tools actions not rendered
- Can't Login Into Admin Portal
- Cant see hours for last row in calendar
- Does the tab page contain data changes? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-suit.