Coder Social home page Coder Social logo

New menu config about django-suit HOT 4 CLOSED

darklow avatar darklow commented on August 28, 2024
New menu config

from django-suit.

Comments (4)

darklow avatar darklow commented on August 28, 2024

Thanks for testing.
I'll fix 1.
2. I choose '/' because that is separator for many wysiwyg editors like ckeditor. I vote for '-' then :)
3. If somebody uses 'url': 'app.model' i don't think it can be by accident, so it means model must be there. I don't like idea of mixing model key also in app level, it is too confusing. This parameter sets nothing but url so i think url key is the right for it.
4. It is quite specific, but i guess it could be useful for others too, for example when linking separate applications/admins together. What do you think, should i add blank=True or more universal target=_blank, i doubt if somebody uses iframes and could need different target than _blank...

from django-suit.

jonashaag avatar jonashaag commented on August 28, 2024

3.: The thing is that you end up having wrong URLs if you have a typo (--> model doesn't exist). On the other hands, it's pretty easy to check for typos in links by just testing them :)

4.: Yeah don't do the target=... thing. I don't think we have to support anything that has anything to do with frames ;)

from django-suit.

darklow avatar darklow commented on August 28, 2024

Could you please test latest version?

from django-suit.

jonashaag avatar jonashaag commented on August 28, 2024

Awesome! Works perfectly.

from django-suit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.