Coder Social home page Coder Social logo

Remove string from messages about django-suit HOT 6 CLOSED

darklow avatar darklow commented on August 28, 2024
Remove string from messages

from django-suit.

Comments (6)

darklow avatar darklow commented on August 28, 2024

After some thought i agreed, i will remove that prefix.

Also i created ticket and PR on Django admin to separate INFO and SUCCESS messages, then we will be able to use "green" style for success messages and "blue" for info, it will be even more describable.

Let's hope it will be accepted
https://code.djangoproject.com/ticket/20111

from django-suit.

skndn60 avatar skndn60 commented on August 28, 2024

I did not realise that there's some "core" Django code involved as well; I have not worked with the default admin for a loooong time... Indeed lets hope they will accept. They're generally not too keen on these changes. Excellent motivation in the ticket!

from django-suit.

skndn60 avatar skndn60 commented on August 28, 2024

I think your ticket was accepted by a core dev! Blimey, that calls for a beer... 👍

from django-suit.

darklow avatar darklow commented on August 28, 2024

"Accepted" is already win, but let's hope it won't take ages to be included and PR accepted :)

from django-suit.

nliberg avatar nliberg commented on August 28, 2024

Unfortunately the prefixes still seem to be included and since they aren't translated they look quite strange. Is the fix for this still held up by changes to the Django core?

from django-suit.

darklow avatar darklow commented on August 28, 2024

@nliberg my PR was accepted 6 months ago, but development cycle for Django is pretty long - my commited changes will be included in Django 1.6 (they already are available in 1.6 beta)

Also you mentioned valid argument, that no one mentioned before - apparently these message titles are not originally translated, therefore i decided to remove them already.

When we will move to BS3, i'll also add some icons (i'll be able to use colors, othwerwise current black icons doesn't look good in alert box), but until now there will be just message.

from django-suit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.