Comments (6)
After some thought i agreed, i will remove that prefix.
Also i created ticket and PR on Django admin to separate INFO and SUCCESS messages, then we will be able to use "green" style for success messages and "blue" for info, it will be even more describable.
Let's hope it will be accepted
https://code.djangoproject.com/ticket/20111
from django-suit.
I did not realise that there's some "core" Django code involved as well; I have not worked with the default admin for a loooong time... Indeed lets hope they will accept. They're generally not too keen on these changes. Excellent motivation in the ticket!
from django-suit.
I think your ticket was accepted by a core dev! Blimey, that calls for a beer... 👍
from django-suit.
"Accepted" is already win, but let's hope it won't take ages to be included and PR accepted :)
from django-suit.
Unfortunately the prefixes still seem to be included and since they aren't translated they look quite strange. Is the fix for this still held up by changes to the Django core?
from django-suit.
@nliberg my PR was accepted 6 months ago, but development cycle for Django is pretty long - my commited changes will be included in Django 1.6 (they already are available in 1.6 beta)
Also you mentioned valid argument, that no one mentioned before - apparently these message titles are not originally translated, therefore i decided to remove them already.
When we will move to BS3, i'll also add some icons (i'll be able to use colors, othwerwise current black icons doesn't look good in alert box), but until now there will be just message.
from django-suit.
Related Issues (20)
- Sidebar is not properly showing HOT 3
- Almost a year without any new merges? HOT 3
- Chosen list in filtered manytomany field is too small to see any chosen selections
- Error 500 on demo HOT 1
- Missing arrow on select with suitv2
- Django Suit v2 Date Inline not showing calendar
- Unable to test an admin action with suit installed HOT 1
- when use npm run build,get a error
- Django Admin Hide Superuser User HOT 1
- Template Issue Filter position v2 HOT 4
- v2 suit tabs not working HOT 1
- Any V1 forks that support Django 3x? HOT 16
- RTL support
- V2 forks on bootstrap5 : need help HOT 2
- add subitems for the suit menu subitems(3 level tree)
- Row styling failing silently?
- object-tools actions not rendered
- Can't Login Into Admin Portal
- Cant see hours for last row in calendar
- Does the tab page contain data changes? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-suit.