Coder Social home page Coder Social logo

Comments (4)

darccio avatar darccio commented on May 20, 2024

Please, can you provide an example showing how are you calling MergeWithOverwrite and what kind of parameters?

from mergo.

aanm avatar aanm commented on May 20, 2024

@imdario Sorry for the delay, my example was more complex so I had to create a simple one.
I also tried with MapWithOverwrite and got the same output, what is the difference between MapWithOverwrite and MergeWithOverwrite?

package test

import (
    "encoding/json"
    "testing"

    "github.com/imdario/mergo"
)

var (
    request    = `{"timestamp":null, "name": "foo"}`
    maprequest = map[string]interface{}{
        "timestamp": nil,
        "name":      "foo",
        "newStuff":  "foo",
    }
)

func TestMergeWithOverwrite(t *testing.T) {
    var something map[string]interface{}
    if err := json.Unmarshal([]byte(request), &something); err != nil {
        t.Errorf("Error while Unmarshalling maprequest %s", err)
    }
    if err := mergo.MergeWithOverwrite(&something, maprequest); err != nil {
        t.Errorf("Error while merging %s", err)
    }
}

from mergo.

darccio avatar darccio commented on May 20, 2024

Ok, working on it. I add it as an unit test and I'm checking it.

from mergo.

darccio avatar darccio commented on May 20, 2024

Done. There was missing an "if" to check if the value from src was nil. I should check if there is another corner case like this in other points of the code.

from mergo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.